From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752988AbcG2NbO (ORCPT ); Fri, 29 Jul 2016 09:31:14 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:50209 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752891AbcG2NbL (ORCPT ); Fri, 29 Jul 2016 09:31:11 -0400 Subject: Re: [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM To: Felipe Balbi , mathias.nyman@intel.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <1469740762-18234-1-git-send-email-robert.foss@collabora.com> <1469740762-18234-2-git-send-email-robert.foss@collabora.com> <87zip1s34e.fsf@linux.intel.com> Cc: Andrew Bresticker From: Robert Foss Message-ID: <2ed918f2-e3eb-6180-655d-1834903f5de4@collabora.com> Date: Fri, 29 Jul 2016 09:31:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87zip1s34e.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-07-28 08:24 PM, Felipe Balbi wrote: > > Hi, > > robert.foss@collabora.com writes: >> From: Andrew Bresticker >> >> Enable runtime PM for the xhci-plat device so that the parent device >> may implement runtime PM. >> >> Signed-off-by: Andrew Bresticker >> Tested-by: Robert Foss >> Signed-off-by: Robert Foss >> --- >> drivers/usb/host/xhci-plat.c | 19 +++++++++++++++++-- >> 1 file changed, 17 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c >> index ed56bf9..fbd45c2 100644 >> --- a/drivers/usb/host/xhci-plat.c >> +++ b/drivers/usb/host/xhci-plat.c >> @@ -246,6 +246,9 @@ static int xhci_plat_probe(struct platform_device *pdev) >> if (ret) >> goto dealloc_usb2_hcd; >> >> + pm_runtime_set_active(&pdev->dev); >> + pm_runtime_enable(&pdev->dev); >> + >> return 0; >> >> >> @@ -274,6 +277,8 @@ static int xhci_plat_remove(struct platform_device *dev) >> struct xhci_hcd *xhci = hcd_to_xhci(hcd); >> struct clk *clk = xhci->clk; >> >> + pm_runtime_disable(&dev->dev); >> + >> usb_remove_hcd(xhci->shared_hcd); >> usb_phy_shutdown(hcd->usb_phy); >> >> @@ -292,7 +297,9 @@ static int xhci_plat_suspend(struct device *dev) >> { >> struct usb_hcd *hcd = dev_get_drvdata(dev); >> struct xhci_hcd *xhci = hcd_to_xhci(hcd); >> + int ret; >> >> + pm_runtime_get_sync(dev); > > you need to check for possible errors here. Ditto to the other occurence > below. > Thanks for the feedback (on this and the 0/2), I'll fix the issues and release a v3.