From: Kieran Bingham <firstname.lastname@example.org> To: Laurent Pinchart <email@example.com>, Simon Horman <firstname.lastname@example.org> Cc: Sergei Shtylyov <email@example.com>, firstname.lastname@example.org, David Airlie <email@example.com>, Daniel Vetter <firstname.lastname@example.org>, "open list:DRM DRIVERS FOR RENESAS" <email@example.com>, open list <firstname.lastname@example.org> Subject: Re: [PATCH] drm: rcar-du: Add r8a77980 support Date: Mon, 9 Dec 2019 12:41:07 +0000 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20190913090359.GC29992@pendragon.ideasonboard.com> Hi Laurent, On 13/09/2019 10:03, Laurent Pinchart wrote: > Hello, > > On Fri, Sep 13, 2019 at 10:21:29AM +0200, Simon Horman wrote: >> On Thu, Sep 12, 2019 at 01:00:41PM +0300, Sergei Shtylyov wrote: >>> On 11.09.2019 22:25, Kieran Bingham wrote: >>> >>>> Add direct support for the r8a77980 (V3H). >>>> >>>> The V3H shares a common, compatible configuration with the r8a77970 >>>> (V3M) so that device info structure is reused. >>> >>> Do we really need to add yet another compatible in this case? >>> I just added r8a77970 to the compatible prop in the r8a77980 DT. That's why >>> a patch like this one didn't get posted by me. >> >> The reason for having per-SoC compat strings is that the IP blocks >> are not versioned and while we can observe that there are similarities >> between, f.e. the DU on the r8a77970 and r8a77980, we can't be certain that >> differences may not emerge at some point. By having per-SoC compat strings >> we have the flexibility for the driver to address any such differences as >> the need arises. >> >> My recollection is that this scheme has been adopted for non-versioned >> Renesas IP blocks since June 2015 and uses of this scheme well before that. > > Sure, but we could use > > compatible = "renesas,du-r8a77980", "renesas,du-r8a77970"; > > in DT without updating the driver. If the r8a77980 turns out to be > different, we'll then update the driver without a need to modify DT. I'm > fine either way, so > > Reviewed-by: Laurent Pinchart <firstname.lastname@example.org> Thanks, This patch has an RB tag from you, and Simon, but alas I don't believe it has been picked up in your drm/du/next branch. Is this patch acceptable? Or do I need to repost? -- Kieran > >>>> Signed-off-by: Kieran Bingham <email@example.com> >> >> Reviewed-by: Simon Horman <firstname.lastname@example.org> >
next prev parent reply other threads:[~2019-12-09 12:41 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-11 19:25 Kieran Bingham 2019-09-12 10:00 ` Sergei Shtylyov 2019-09-12 10:26 ` Kieran Bingham 2019-09-12 10:45 ` Kieran Bingham 2019-09-12 12:03 ` Geert Uytterhoeven 2019-09-12 12:11 ` Kieran Bingham 2019-09-13 8:21 ` Simon Horman 2019-09-13 8:30 ` Geert Uytterhoeven 2019-09-13 8:57 ` Simon Horman 2019-09-13 9:03 ` Laurent Pinchart 2019-12-09 12:41 ` Kieran Bingham [this message] 2019-12-13 0:48 ` Laurent Pinchart 2019-12-16 9:47 ` Kieran Bingham 2019-12-16 10:37 ` Geert Uytterhoeven 2019-12-17 23:11 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] drm: rcar-du: Add r8a77980 support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).