From: Vladimir Zapolskiy <vz@mleia.com>
To: Dario Binacchi <dariobin@libero.it>, linux-kernel@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>,
Drew Fustini <drew@beagleboard.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 3/3] pinctrl: single: set pinmux from pins debug file
Date: Fri, 21 May 2021 09:44:09 +0300 [thread overview]
Message-ID: <2ef7f7f9-b147-8292-85fb-bcf58a2b6428@mleia.com> (raw)
In-Reply-To: <20210520202730.4444-4-dariobin@libero.it>
Hello Dario,
On 5/20/21 11:27 PM, Dario Binacchi wrote:
> As described in section 9.1 of the TI reference manual for AM335x [1],
> "For writing to the control module registers, the MPU will need to be in
> privileged mode of operation and writes will not work from user mode".
> By adding the pin_dbg_set helper to pcs_pinctrl_ops it will be possible
> to write these registers from the pins debug:
this makes little sense, because it should be possible to write to the
registers without introduction of this interface, pin group/function
is the right level of abstraction for your particular task.
> cd /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single/
> echo <pin-number> <reg-value> >pins
>
> [1] https://www.ti.com/lit/ug/spruh73q/spruh73q.pdf
>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
I strongly object against this new interface to be added.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2021-05-21 6:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 20:27 [PATCH v3 0/3] am335x: set pinmux registers from pins debug file Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 1/3] docs/pinctrl: update `pins' description under debugfs Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 2/3] pinctrl: core: configure pinmux from pins debug file Dario Binacchi
2021-05-21 6:44 ` Vladimir Zapolskiy
2021-05-24 17:28 ` Dario Binacchi
2021-05-24 18:52 ` Vladimir Zapolskiy
2021-05-25 5:15 ` Tony Lindgren
2021-05-27 19:23 ` Dario Binacchi
2021-05-27 19:57 ` Vladimir Zapolskiy
2021-05-27 20:33 ` Dario Binacchi
2021-05-28 8:34 ` Vladimir Zapolskiy
2021-05-28 9:07 ` Linus Walleij
2021-06-02 5:03 ` Tony Lindgren
2021-06-11 8:29 ` Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 3/3] pinctrl: single: set " Dario Binacchi
2021-05-21 6:44 ` Vladimir Zapolskiy [this message]
2021-05-25 0:18 ` [PATCH v3 0/3] am335x: set pinmux registers " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ef7f7f9-b147-8292-85fb-bcf58a2b6428@mleia.com \
--to=vz@mleia.com \
--cc=andy.shevchenko@gmail.com \
--cc=dariobin@libero.it \
--cc=drew@beagleboard.org \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).