From: Kashyap Desai <kashyap.desai@broadcom.com>
To: John Garry <john.garry@huawei.com>, axboe@kernel.dk
Cc: ming.lei@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, hare@suse.de
Subject: RE: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags
Date: Tue, 19 Oct 2021 00:19:13 +0530 [thread overview]
Message-ID: <2f09315210261e82c42a1353cab48dcd@mail.gmail.com> (raw)
In-Reply-To: <1634550083-202815-1-git-send-email-john.garry@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
> -----Original Message-----
> From: John Garry [mailto:john.garry@huawei.com]
> Sent: Monday, October 18, 2021 3:11 PM
> To: axboe@kernel.dk
> Cc: ming.lei@redhat.com; linux-block@vger.kernel.org; linux-
> kernel@vger.kernel.org; kashyap.desai@broadcom.com; hare@suse.de; John
> Garry <john.garry@huawei.com>
> Subject: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared
tags
>
> Since it is now possible for a tagset to share a single set of tags, the
iter
> function should not re-iter the tags for the count of #hw queues in that
case.
> Rather it should just iter once.
>
> Fixes: e0fdf846c7bb ("blk-mq: Use shared tags for shared sbitmap
support")
> Reported-by: Kashyap Desai <kashyap.desai@broadcom.com>
> Signed-off-by: John Garry <john.garry@huawei.com>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> ---
> Diff to v1:
> - Add Ming's RB tag
Now I noticed proper host_busy in my test. Still CPU hogging is not
resolved, but issue addressed by this patch is resolved.
Tested-by: Kashyap Desai <kashyap.desai@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2021-10-18 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 9:41 [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags John Garry
2021-10-18 18:49 ` Kashyap Desai [this message]
2021-10-21 8:08 ` John Garry
2021-10-21 14:21 ` Jens Axboe
2021-12-09 13:52 ` Kashyap Desai
2021-12-09 14:42 ` John Garry
2021-12-13 13:15 ` Kashyap Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f09315210261e82c42a1353cab48dcd@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).