From: David Ahern <dsahern@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
David Ahern <dsahern@gmail.com>, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com,
jiri@mellanox.com, idosch@idosch.org
Subject: Re: [PATCH v2 iproute2-next] bridge: add support for L2 multicast groups
Date: Fri, 6 Nov 2020 09:40:12 -0700 [thread overview]
Message-ID: <2f127ed7-a816-bb13-0be2-68b19eef78fb@gmail.com> (raw)
In-Reply-To: <20201029222828.2149980-1-olteanv@gmail.com>
On 10/29/20 4:28 PM, Vladimir Oltean wrote:
> @@ -168,9 +176,14 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e,
> print_string(PRINT_ANY, "port", " port %s",
> ll_index_to_name(e->ifindex));
>
> + if (af == AF_INET || af == AF_INET6)
> + addr = inet_ntop(af, grp, abuf, sizeof(abuf));
> + else
> + addr = ll_addr_n2a(grp, ETH_ALEN, 0, abuf, sizeof(abuf));
> +
The above can be replaced with a single call to rt_addr_n2a_r.
> print_color_string(PRINT_ANY, ifa_family_color(af),
> - "grp", " grp %s",
> - inet_ntop(af, grp, abuf, sizeof(abuf)));
> + "grp", " grp %s", addr);
> +
> if (tb && tb[MDBA_MDB_EATTR_SOURCE]) {
> src = (const void *)RTA_DATA(tb[MDBA_MDB_EATTR_SOURCE]);
> print_color_string(PRINT_ANY, ifa_family_color(af),
I think the rest is ok.
prev parent reply other threads:[~2020-11-06 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 22:28 [PATCH v2 iproute2-next] bridge: add support for L2 multicast groups Vladimir Oltean
2020-11-06 16:40 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f127ed7-a816-bb13-0be2-68b19eef78fb@gmail.com \
--to=dsahern@gmail.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).