From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752006AbdKMHQq (ORCPT ); Mon, 13 Nov 2017 02:16:46 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:27150 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbdKMHQo (ORCPT ); Mon, 13 Nov 2017 02:16:44 -0500 Subject: Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup To: Johan Hovold , Dmitry Torokhov References: <20171111154339.16875-1-johan@kernel.org> CC: , , stable , Marek Belisko From: Peter Ujfalusi Message-ID: <2f1d38a1-2646-1c9a-ccb7-62f8a62ca110@ti.com> Date: Mon, 13 Nov 2017 09:17:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171111154339.16875-1-johan@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-11-11 17:43, Johan Hovold wrote: > A helper purported to look up a child node based on its name was using > the wrong of-helper and ended up prematurely freeing the parent of-node > while searching the whole device tree depth-first starting at the parent > node. > > Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel") > Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning") > Cc: stable # 3.7 > Cc: Peter Ujfalusi > Cc: Marek Belisko > Signed-off-by: Johan Hovold Acked-by: Peter Ujfalusi > --- > drivers/input/misc/twl4030-vibra.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c > index 6c51d404874b..c37aea9ac272 100644 > --- a/drivers/input/misc/twl4030-vibra.c > +++ b/drivers/input/misc/twl4030-vibra.c > @@ -178,12 +178,14 @@ static SIMPLE_DEV_PM_OPS(twl4030_vibra_pm_ops, > twl4030_vibra_suspend, twl4030_vibra_resume); > > static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata, > - struct device_node *node) > + struct device_node *parent) > { > + struct device_node *node; > + > if (pdata && pdata->coexist) > return true; > > - node = of_find_node_by_name(node, "codec"); > + node = of_get_child_by_name(parent, "codec"); > if (node) { > of_node_put(node); > return true; > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki