From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752117AbdCMK2B (ORCPT ); Mon, 13 Mar 2017 06:28:01 -0400 Received: from mail-bn3nam01on0069.outbound.protection.outlook.com ([104.47.33.69]:4043 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750993AbdCMK1x (ORCPT ); Mon, 13 Mar 2017 06:27:53 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler To: Moritz Fischer , References: <1489181435-3151-1-git-send-email-mdf@kernel.org> <1489181435-3151-2-git-send-email-mdf@kernel.org> CC: Rob Herring , Mark Rutland , linux-arm-kernel , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Linux Kernel Mailing List , Devicetree List From: Michal Simek Message-ID: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> Date: Mon, 13 Mar 2017 11:27:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-22938.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39410400002)(39850400002)(39840400002)(2980300002)(438002)(24454002)(189002)(199003)(377454003)(9170700003)(86362001)(83506001)(6666003)(5660300001)(47776003)(2950100002)(76176999)(4326008)(31696002)(36386004)(229853002)(65826007)(50466002)(54356999)(50986999)(36756003)(53546006)(4001350100001)(189998001)(81166006)(8676002)(23676002)(77096006)(305945005)(8936002)(356003)(33646002)(38730400002)(9786002)(54906002)(2906002)(65956001)(65806001)(6246003)(31686004)(2870700001)(63266004)(106466001)(6306002)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR02MB1381;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT030;1:PDqPNmHx7Awkfp4AE8QCp1T3Jdl9Q5/XV+FcYJLajPHXP+/XsGVGOn975hDTIWL3melbc8uXA85Vn9fDxqZSaQCMxg3GiFxsvVWGWzVD+ZuYf1PRzME7k5oMnJk8XsuUhnL182lz1HXp5bLOoypSoucYWqFsIjz9CgoafTeddwrEXKtYwaTxRqdgBZUtE2EzEvg791mn02cF1acP8rbefKR1k4Upx2Y3wij+5mF4gOaTz9BVQplnl1V8mGFDtHTyTpNRdsuS5RWKyciDrh71j0bkilomlVsPNK4MGLsNfwbLzqo7gRtvgj+yYPSF5r0pM0EfSAyArc35SiG/F2F0rg1YwHrJ3flXnWQAoG4f2dCWbHP3iIOO/XMrXXkaBanqeUyQcj/iD61Mtu7PdYe1A3Trntsxjme6qlLBjESlbOUncgTZEtCNrmZikt37AO5cvSCGCKEyHd/YQiL/DhZKu5xJrh7c3aGOJ2ehOAVHWtMkq8WdD71TVxpCfO1Ee1e0jyYOUE1dYHGu9m2S1bFVBIH42Bid2/Yt0dqWMsmsee/Iy8vhWr17YTJtgAEEu3Ikx1rKqFE0fa2p54XyUf8q/AphGNwXgRRMYz65ybFt/nw= X-MS-Office365-Filtering-Correlation-Id: 594f5072-a534-470e-e0a0-08d469fb9810 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:CY1PR02MB1381; X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1381;3:LeLzZiCbJ7V0uwhUFXLhMdj0SHECemYRZ4xF1OoIT2viGTgZk2x5xhyvxhnVy55g9r5Acf1jbzBWUjYn8hrubBRKkaS5qgRTyEyc2zrB3ffmEDgZ/aDU1/wxlRYlIE8si4b8hzm87mo+wKAqgC5qdF3Csvpf3iAVT2+/zT44yZ63zSwNA7tUwajVbQ4jEzr/fbKuBMVmA8DTXUEpr0KOLm3ZTTeQXobbwLehqiwIYAiNH+7hhKCjXZGOWDj3BvkhIQaxW61dnc7wv8LJD2uVKMrax28gh2up1az9gzHMv4QHhxZ+Bn2OlgKEjQM9fyqZ6Wzh+h60GFQR2ZntI5ijjkCAfsw8tnaq9QLfzVplm9yle5dgP2wxMd2X7AZm0Ku2Y3gixgJTWqer9qg0deywZQ==;25:uDntAB54Eq/PFgeQQoQRUZpjhi3h716u3q/YW7uqC2KI9Trpr0H1RVR4jCCpaoOx6mabsXpoULlKO2asm++DYiveME+vrumhrPb8KYZYAtjyxmF+thWcpAGLr1FiUEv67EXvGYYxshuYvrRyibxmpTjlXp0lGumLB/s0xMyeOx+15xjp42nUylT/G4TeepwVijuhejohHcJj/LWehv7HtAsKCx7kQuUDjqwU/K14Qo49XR+sEzfCRzWeoSzEqUsGFsNx2SW1Xld7bFV65QlryTZN7KA8MnRM1mkMSbYTcDhd3ZZXCO31FmMbx8AsyFx7VHafSvh5ehu+fXSAFrTCSyUEZY8Gt6YFf6noYRG8j2pP47KHfYm1klbkHNZ04Pg6wRrIQz3Rx7SC+98Nnmn+LzISS3gZl+YjnkrdDeEoWq+gpkXLWYr0K4yBKqA3Fzvb8Y2vW1CZydbj3xtQwNshrQ== X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1381;31:7iibooN0YkzLZjQA3D9RpSLL2Vg+zQwlaO4jQoE/UOSctvzPfRKCU2077xTLN6y5PTLHMFfPchmGktDFkFlpNabJg/i9B74LgKyN554G/KypEpRA8mFVIRC1y2YTeQFMOGLggLImSy+u+Vj0XkSxLC+Uv4q0tgzF3bjtN5vW5TJnfX0Dre0Wb9sdnK5uSBSY9tcleS6cvQTw2UIQ+mCUim3zmp8CHJ8c7kln8iQnbj1krTR6nmmGNa5G4T6X4Dkc8HvkOdD0MKNobCfPLWTNFQ==;20:kPRyMb35GjX/2VuKpX/y7IOnEMwmFEfjZzu2CLJCDmc9cayjavnyCpy9/x7tIBT14BehNZCBnpvrI0i6WdGnjQKnCQX2VEo44tWBR9mEmuPwbMDzkP18Oq92oVho9EOziVSPoPAI31bI0nTdm11EnElZtHkbdACCZlV/PChPuGao1zXuQMjxjPE3q1SE/7UEJ7KXaINCP98nCV9pGuWk0rNEb/XvkBWfayKSXsSYW9nRMPAMqiQ8BYpB9VamKvOox4bwNolAnf5AU80Bm2jecpPNtNW7FTgAgJwKRkz48zjLN0VLdMhAiwMdmm8gzEsmeUACtuJSigzo1IBCvXJazy27F6LNfNENgcwn3EDMSSMpVhIKl95dKri0MWTLvYTOJhMK56jFDnUgq9i/zR7+d7ABa+5OvLR0tlNxgFNjkY2hF+aMmIYupFPahi52dNV73v6VD6LS1Kb9JkJy6BezK9xO87kb/GP4EZ9YG+CxPAeZpKZJUHQM7UXqfbvCSkqb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820)(9452136761055)(192813158149592)(21532816269658); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13023025)(13018025)(13024025)(13015025)(13017025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123558025)(20161123560025)(20161123564025)(6072148);SRVR:CY1PR02MB1381;BCL:0;PCL:0;RULEID:;SRVR:CY1PR02MB1381; X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1381;4:2TYvDgsWq+mMnQ99WsMEiDd4zlJvjBUB0kTg/ZR/xCmTyrLZNUiGy5yarwOb/dQUy+1Lk+SiO7GJY2pb48SC/hIIR2MmzAVtelRylqTYGwpzbMSLUHfF2voaVVJjt6X1akDRoCwQSGkBanKCFtECwb08S/Q1iyb3/Et1eej9PRvcV5WSuzB8ECb9Q0LPA2DolD0IeiGCe8ss2IbmMrpDeIIb16FiqfM+XUkJWhrpMNzybKE/m5E4L7Ky3U0IarwHy0AszIwilTJ0Tu7kZcyZVqb9vXtwZadJXDXxicMxvEXaHDuHOXrOD93ImEGpDdu2eyDNY73cefomHXADWfwc7SD0lhK8sPYpJAxoBO60pNMd9I/dpymF9p5FaGw6g+I7EACTyxL8j4+W/0vbqFeNkGaQK/lWZvR2IlR1sH4PjjNlx+fgSLd642QtgmAUlLn0Uu9GTR6PZAsdwogujAtG/69FH8Co1EWkJ/ZPWroRMMBQlINIU+weje3dlkOAFBg1SZ7t19LOFBvadYOJxzcQqFZP0OWGbfJUr/L60izSj7CX8PFvDNavsHfKyPBa1YfbCU9b0MTXbkOizyN+RbZ8nRSr4qw7khs6PfZipCMY/t6lf5HLHq0uJPpSwqKBZUDx+ZoxP/JlR0HygsjRwtjT0Z/D41Xwczt9wlWPLiPtxOzXGr/fKfEPnsWZ1Sc9R4/lPSeaVpogbeWg0Ks1+B4Ar/0vg4nLDkUmInGfcrWKjBi6qrRvThNlWAZsG7+fyTRg6FNq8WPlFR1ZaWd1hx86Y+TJ2f83c2GB5UonfQQAyWhvjJ/S22lzpE1FmLNW/EI7V9cSr2x43YV59H3Vkznwo5A7JqrdhE/brjpmUZJdAVc= X-Forefront-PRVS: 0245702D7B X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAyTUIxMzgxOzIzOk9SU2tUeFBqMERVTENZNE5JZTEwYnF1bDRM?= =?utf-8?B?VFlmQUVXeS8vU1U5b0Z2MDdqZzhYbFFISnZBeWhKdFczYk1NZ3VuZExyb0la?= =?utf-8?B?ei9STEdTZWFYY0ppSTRTd3pIbVVOMkNOOVFpNTR1YmdJRS9LSlA1QUdmMFNk?= =?utf-8?B?dDJiMlIxN21mSTFOQmMxbEYwRUlpdjhtN0RpQVdwaFFjMm4vRE9wTkYxQU12?= =?utf-8?B?TnI4bGRMdEIydFRSSHA2dFJjakV6Z3E4S2JpN2xlcFBjT21VM0c1T0RkTnNk?= =?utf-8?B?SU1YRS9LZVZ6aFVXbFg3Rm1JVDNMdDl3TjZWZ1hSZnNvc3hvZGkvazRxN1Vo?= =?utf-8?B?ZC9ZRnZXU1N1aVUyZXRJSEg3RWpSVkQxcWRldlhjUXVZbGhyZ1ZodGtUbGp3?= =?utf-8?B?NGtXdlFDZURoOGgxLzJOcWF0bDJyUW81QWZOa2ljdjNkZTExbG9yZTNidjQz?= =?utf-8?B?MSszQ2tQZFc2c3lPSzhzN1I1Q2FodzVRN2ljbU5PUHBveUowTGduNWQ4QmM1?= =?utf-8?B?TVl3aXk4SXpibk05bU5lUDgvSG9xd1JBNGEySEZwNnZwdy9KSzB2VndYQUt2?= =?utf-8?B?OE1PejdORm96RzNhR2FWalJ3c0I0UEFDc1ZvRFlYd0p5VzZWWTJORG0rVjZx?= =?utf-8?B?ckZEU0hxTkplTU8rQTNBeTFtbXdCemxndXFCVXhlRnB4YVlZZmNUcEMrUEgy?= =?utf-8?B?TWwrYVJwMDR3a2drcDdtTW9vMjloY1JENXJmOGJUd1BIbWkvSWNISzFpNThU?= =?utf-8?B?YnI0bVB1US9GYm44NVdqZHEyRlBkbFl6NVFPZWVQa2UzemlDeUlZUnIyY0hs?= =?utf-8?B?K1l3S2MvTmFncnk4SWgxQTZXMit0eDcyNFpURDVONEE3ZnlkQjhHSE4zNEZO?= =?utf-8?B?KzA5OFZya0hhc1Zpb2loUjcvQXZkdFpTcFl1eXFiNzRld2VsSy9KN3QvQ1NQ?= =?utf-8?B?S3YvSlpUaXlJUi8ydzJEekVpb2tTNFl2SEFiMytBTmRvWmZEVXpYSDlEZ0I5?= =?utf-8?B?L1lzb0hZTTJtQStUNDZHVHNQa0svZ1BUYyt0b3ozeHhnV3FsM0hWVHg4WWVR?= =?utf-8?B?Q3J0emdLbmtNYk1vWmZQVmZvalpyMVA4SWZERXc3OHowbE1sU24reTU1M0RF?= =?utf-8?B?cUtBSnVDOTZUUklHenRLOVVqWUJzaXYwUmVDVkgzMS95NUU1OVp4YUpTRXJm?= =?utf-8?B?YWIySmFXMi96Q0JMb3B2N0pSVVA1VE1yREc1R1hISUoyVjJRSEhDV0xUMFN5?= =?utf-8?B?UndxUnNBVmFjNXpUeVdpdUZQTmFNdC9zN1l1TlVESW9ETS9HR3k5WkNwckRi?= =?utf-8?B?cm5jeGVDL0JRM0Y3dzMyR3BjWko0NDhSZUdGUVNuT0tHVER5Vzd4ZlhOV3FI?= =?utf-8?B?VTRXR2hFMkEvYnBpYkxmRmlCMExsK1hlMDJNWVRBNUFHblFCTFM3MjdSQWRp?= =?utf-8?B?cy9lNUZrRXJJdzZiS1VVOGhvcUR3NXVXOHplVnRmREJWSVFoSmtPUXhSaVJl?= =?utf-8?B?NFpBd242cGdwMWIzVmFMR3UzUUFVNjFjVEloNjdRTGhBVnhZK3F4a0Z0THoz?= =?utf-8?B?M3RNSVJzZXRZRmsxZlhrLyt5Zm43cUZGTjFhdklsVENMTDMzQjJKOWFzRkV4?= =?utf-8?B?Z29sSTFUTzJLbWY0Sy8xb0hSSWhHZkIrcnh2Y3dzb3dYaWVxdWg0OWk3N3g4?= =?utf-8?Q?aQIBC8h0B7p7MYuquLmv9CUNR1eQYPSMfOCbffx?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1381;6:LUfLLL7Tdx+/3HddE0Sraw+BgnC2pcvKJkjgV85X8Conj/p8128/5wMsYviLUWqwByT6iaZivgWXwKOaXvGtjDJHsxyet/ywnrl5NmJWHi8iNnPVn3MW5MHEhIEjjRjLgFyHETUBWAx+sAwH4GJodmPGEUBgywZdL434SXzD81hEn78KYxpnKrBxv3PchuqmIjq4ofUDEMRCIdmHZ8yBDDPQ8DV50mCWCUR5jlWnfojuBrpFa0a015j7n56F2yeSCiwfgIItF3Ch8wHXoaTh7M0CItT0ieWPm1/WZO0YGycRWOQUAvgTzCfLLPri40JpaBRNEvoKxTEZnXET9y4v2Q85YMQtPSwOZbWn0oOMxcwEZOzfk10Zbw2nVKxAAJP+1e0QhRTJyfM5TCS6lq2JDr/6BAfgzbZD0T2Oajbh64Y=;5:kxAbudKtgvrD+7+taY+U/t/faXLye3e3IsP9yRfcJXMchd64WqLXphmtMlyn4qhjdxUgYnVEUOANKL6cV1oGR7WVBBANzYIJ1awSDFhDIFnrFJbLLThof1+U/XNjSvF/uKoBKJUJ/x1MJC3t22PmYJziVZ6LyQwMM6LUgseoTm4=;24:2YZ3kLlp4V5z4omNZ8WmyCafjcRmCcIjrMebrQu1dVN5Uy6josEWtHpwfRBWH7+gYgy8mCmmN0algMB3ukOreq4KbBAOUfcCJ+iVbxYQWD8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1381;7:JTCeGzcpETdH+0RnetOkUeBQ/UFXFOMaySeWrrnWnNje70rdzaRy/A6OWIKpMdtM5MZa/lPtAeg5I+OQ2B0jhvcyrh1SwR5My4obHcaKoC+VZa1DJ6+g1MY5AESeQna1EOSHAmpQJRA0qUyuNATKWaSpB+wHefnn2MlUT+SkI+669iCx7RGwkqlGdKAJS2aOsE2tcOyuSN5pQIJVxk/YpHHOANAxpBka3yzxZ4WsjSijWPmOhTPbyNTLC6HWhY+7XzDHy5y+/bIRClGtfoHLiWuuTR83jlrrp9Ruj0Kw83zt83FMXwNRTXB7BXbhIP8KtcDhhU4FfeNLsgnAdidyMA== X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2017 10:27:47.1908 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1381 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Moritz, On 10.3.2017 23:42, Moritz Fischer wrote: > On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer wrote: >> This adds support for the Xilinx LogiCORE PR Decoupler >> soft-ip that does decoupling of PR regions in the FPGA >> fabric during partial reconfiguration. >> >> Signed-off-by: Moritz Fischer >> Cc: Michal Simek >> Cc: Sören Brinkmann >> Cc: linux-kernel@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> --- >> drivers/fpga/Kconfig | 9 +++ >> drivers/fpga/Makefile | 1 + >> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 166 insertions(+) >> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c I have written very similar driver some week ago but didn't sent it out. Here it is. https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c Your clk handling is better and my enable_show is better. You shouldn't rely on setting status before. It is better to read that reg again. The reason is you can connect status signal from one PR decoupler to decouple input which can change status There is another topic I wanted to open in connection to this. There should be gpio based bridge because this pr decoupler can be without axi interface and for that gpio driver would be useful. Thanks, Michal