From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C36C33CA2 for ; Fri, 10 Jan 2020 00:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC16B2077C for ; Fri, 10 Jan 2020 00:23:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Yb89A2gv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730193AbgAJAXZ (ORCPT ); Thu, 9 Jan 2020 19:23:25 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:34640 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730093AbgAJAXZ (ORCPT ); Thu, 9 Jan 2020 19:23:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KHYqPOLkvD0DruHaQLvI+6S0eV5ygHhxNMiENbeQCNo=; b=Yb89A2gvn+1hy4rS/2JNVOaHs QZWgF57IYhbnSQQQOTuOe6Aa0UNp7kTyuUVHPxK3KL793c+uzrrLMoIIUz+FAck5UuP0FLBiPLk9H fiOvgxTl0FG5Bl8IYo6Q9qLltGiSfxShteNWSIEAX5Zj0HKd06QASrk4kwZ+jRRJuyEBkqVEpcyoc +H1CZGxDdBiaPX9eAQ2GTf9auakmhm1Oxp7L4Yb5pvuy6i5R5OmHFZOOqk5tB1XMnjOXy7QlKQhfe lxZlNYvWSkEz7uT9KzXw0QypWL0PSUHboONZ12GVBPxktOP++70hYLSCx2D4YmUGVlX/v45T79urh soxbRylYg==; Received: from [2601:1c0:6280:3f0::ed68] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipi4j-0004Ao-09; Fri, 10 Jan 2020 00:22:53 +0000 Subject: Re: [PATCH v27 12/12] LRNG - add power-on and runtime self-tests To: =?UTF-8?Q?Stephan_M=c3=bcller?= , Arnd Bergmann Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman , Julia Lawall References: <6157374.ptSnyUpaCn@positron.chronox.de> <2722222.P16TYeLAVu@positron.chronox.de> <2641155.iNH938UiKq@positron.chronox.de> <2355906.JbblJTOqSk@positron.chronox.de> From: Randy Dunlap Message-ID: <2f225250-c1e1-c6e1-026c-9c63853ab7d1@infradead.org> Date: Thu, 9 Jan 2020 16:22:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <2355906.JbblJTOqSk@positron.chronox.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 1/9/20 12:35 AM, Stephan Müller wrote: > --- > drivers/char/lrng/Kconfig | 25 ++ > drivers/char/lrng/Makefile | 1 + > drivers/char/lrng/lrng_selftest.c | 418 ++++++++++++++++++++++++++++++ > 3 files changed, 444 insertions(+) > create mode 100644 drivers/char/lrng/lrng_selftest.c > > diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig > index 394066aa5a86..e9827e7df715 100644 > --- a/drivers/char/lrng/Kconfig > +++ b/drivers/char/lrng/Kconfig > @@ -175,4 +175,29 @@ config LRNG_TESTING > > If unsure, say N. > > +config LRNG_SELFTEST > + bool "Enable power-on and on-demand self-tests" > + help > + The power-on self tests are executed during boot time self-tests > + covering the ChaCha20 DRNG, the LFSR processing and the > + time stamp management of the LRNG. > + > + The on-demand self-tests are triggered by writing any > + value into the SysFS file selftest_status. At the same > + time, when reading this file, the test status is > + returned. A zero indicates that all tests were executed > + successfully. > + > + If unsure, say Y. > + > +if LRNG_SELFTEST > + > +config LRNG_SELFTEST_PANIC > + bool "Panic the kernel upon self-test failure" > + help > + If the option is enabled, the kernel is terminated if an > + LRNG power-on self-test failure is detected. > + > +endif # LRNG_SELFTEST > + > endif # LRNG -- ~Randy