From: Steven Whitehouse <swhiteho@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [git pull] mount API series
Date: Sat, 10 Nov 2018 14:19:44 +0000 [thread overview]
Message-ID: <2f4a2d58-dc7b-3a8f-65aa-9db432ce0a1e@redhat.com> (raw)
In-Reply-To: <87a7mut9cm.fsf@xmission.com>
Hi,
On 31/10/18 15:38, Eric W. Biederman wrote:
> Al Viro <viro@ZenIV.linux.org.uk> writes:
>
>> mount API series from David Howells. Last cycle's objections
>> had been of the "I'd do it differently" variety and with no such
>> differently done variants having ever materialized over several
>> cycles...
> Absolutely not.
>
> My objections fundamentally is that I can find real problems when I look
> at the code. Further the changes have not been incremental changes that
> have evolved the code from one state to another but complete
> replacements of code that make code review very difficult and bisection
> completely inapplicable.
>
> I also object that this series completely fails to fix the worst but I
> have ever seen in the mount API. Whit no real intrest shown in working
> to fix it.
>
> A couple of bugs that I can see quickly. Several of which I have
> previously reported:
>
> - There is an easily triggered NULL pointer deference with open_tree
> and mount propagation.
>
>
Can you share some details of what this NULL dereference is? David and
Al have been working on the changes as requested by Linus later in this
thread, and they'd like to tidy up this issue too at the same time if
possible. We are not asking you to actually provide a fix, in case you
are too busy to do so, however it would be good to know what the issue
is so that we can make sure that it is resolved in the next round of
patches,
Steve.
next prev parent reply other threads:[~2018-11-10 14:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 5:33 [git pull] mount API series Al Viro
2018-10-31 15:38 ` Eric W. Biederman
2018-10-31 16:18 ` Eric W. Biederman
2018-10-31 16:36 ` Al Viro
2018-11-01 16:51 ` Al Viro
2018-11-10 14:19 ` Steven Whitehouse [this message]
2018-11-12 2:07 ` Eric W. Biederman
2018-11-12 20:54 ` Al Viro
2018-12-17 23:10 ` Al Viro
2018-12-21 16:25 ` Eric W. Biederman
2018-10-31 16:18 ` Linus Torvalds
2018-11-01 10:53 ` Steven Whitehouse
2018-11-01 15:57 ` Linus Torvalds
2018-11-01 17:18 ` David Howells
2018-11-01 18:33 ` Linus Torvalds
2018-11-01 22:05 ` Al Viro
2018-11-01 22:07 ` Linus Torvalds
2018-11-01 23:59 ` David Howells
2018-11-02 4:07 ` Al Viro
2018-11-02 19:42 ` Al Viro
2018-11-03 6:14 ` Gao Xiang
2018-11-03 6:30 ` Gao Xiang
2018-10-31 18:39 ` David Howells
2018-10-31 20:49 ` Miklos Szeredi
2018-10-31 18:45 ` [PATCH] vfs: Fix incorrect user_ns assignment in proc and mqueue David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f4a2d58-dc7b-3a8f-65aa-9db432ce0a1e@redhat.com \
--to=swhiteho@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).