From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A389C1550A for ; Fri, 5 Mar 2021 12:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7597665037 for ; Fri, 5 Mar 2021 12:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231805AbhCEM1O (ORCPT ); Fri, 5 Mar 2021 07:27:14 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:40624 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbhCEM0t (ORCPT ); Fri, 5 Mar 2021 07:26:49 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DsRn34C3Cz1qsZs; Fri, 5 Mar 2021 13:26:47 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DsRn33TjWz1t6p6; Fri, 5 Mar 2021 13:26:47 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id oKW_NzhLEexk; Fri, 5 Mar 2021 13:26:46 +0100 (CET) X-Auth-Info: 7sNqH9INcwCoYmH9P1rkueSRV97XCQQxSO/sSqCJ1pc= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 5 Mar 2021 13:26:46 +0100 (CET) Subject: Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Roman Guskov References: <20210305120240.42830-1-andriy.shevchenko@linux.intel.com> <506c1e48-c648-69d4-8e4f-b42fe02156f7@denx.de> From: Marek Vasut Message-ID: <2f567d44-4aaa-02f7-a60f-d6ad5404373a@denx.de> Date: Fri, 5 Mar 2021 13:26:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/5/21 1:24 PM, Andy Shevchenko wrote: > On Fri, Mar 05, 2021 at 01:11:39PM +0100, Marek Vasut wrote: >> On 3/5/21 1:02 PM, Andy Shevchenko wrote: >>> On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, >>> see arch/arm/boot/dts/stm32mp151.dtsi. The driver for >>> pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c >>> and iterates over all of its DT subnodes when registering each GPIO >>> bank gpiochip. Each gpiochip has: >>> >>> - gpio_chip.parent = dev, >>> where dev is the device node of the pin controller >>> - gpio_chip.of_node = np, >>> which is the OF node of the GPIO bank >>> >>> Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node), >>> i.e. pin-controller@50002000 != pin-controller@50002000/gpio@5000*000. >>> >>> The original code behaved correctly, as it extracted the "gpio-line-names" >>> from of_fwnode_handle(chip.of_node) = pin-controller@50002000/gpio@5000*000. >>> >>> To achieve the same behaviour, read property from the firmware node. >>> >>> Fixes: 7cba1a4d5e162 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties") >>> Reported-by: Marek Vasut >>> Reported-by: Roman Guskov >>> Signed-off-by: Andy Shevchenko >> >> Tested-by: Marek Vasut >> Reviewed-by: Marek Vasut > > Thanks! > >> Thanks >> >>> static int devprop_gpiochip_set_names(struct gpio_chip *chip) >>> { >>> struct gpio_device *gdev = chip->gpiodev; >>> - struct device *dev = chip->parent; >>> + struct fwnode_handle *fwnode = dev_fwnode(&gdev->dev); >> >> You could make the order here a reverse xmas tree, but that's a nitpick. > > They are dependent, can't be reordered. Doh, you're right.