From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-team@lge.com
Subject: Re: [PATCH v13 3/3]: perf record: extend trace writing to multi AIO
Date: Fri, 12 Oct 2018 13:21:19 +0300 [thread overview]
Message-ID: <2f711022-41ec-275c-7f9f-a1f269b23b37@linux.intel.com> (raw)
In-Reply-To: <20181012094901.GA22076@sejong>
Hi,
On 12.10.2018 12:49, Namhyung Kim wrote:
> Hi,
>
> On Thu, Oct 11, 2018 at 09:59:19PM +0300, Alexey Budankov wrote:
>>
<SNIP>
>> @@ -1882,8 +1913,8 @@ static struct option __record_options[] = {
>> OPT_BOOLEAN(0, "dry-run", &dry_run,
>> "Parse options then exit"),
>> #ifdef HAVE_AIO_SUPPORT
>> - OPT_CALLBACK_NOOPT(0, "aio", &record.opts,
>> - NULL, "Enable asynchronous trace writing mode",
>> + OPT_CALLBACK(0, "aio", &record.opts,
>> + "n", "Use <n> control blocks in asynchronous trace writing mode (default: 1, max: 4)",
>
> One question. It seems you used a very large N in your test result.
> Why did you limit it to 4 here? Is it something different? Maybe
> you'd better making it a macro constant for future changes..
Yes, it's less than values used during metrics measurements.
There is still no good rationale behind top border value
because currently it is a kind of implementation detail.
Defining as a macro makes sense for easier source code management.
Thanks,
Alexey
>
> Otherwise looks good to me. For the 3 patches
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
next prev parent reply other threads:[~2018-10-12 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 18:35 [PATCH v13 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-10-11 18:51 ` [PATCH v13 1/3]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-10-11 18:55 ` [PATCH v13 2/3]: perf record: enable asynchronous trace writing Alexey Budankov
2018-10-11 18:59 ` [PATCH v13 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
2018-10-12 9:49 ` Namhyung Kim
2018-10-12 10:21 ` Alexey Budankov [this message]
2018-10-12 14:17 ` Jiri Olsa
2018-10-12 16:28 ` Alexey Budankov
2018-10-14 14:06 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f711022-41ec-275c-7f9f-a1f269b23b37@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).