From: Robin Murphy <email@example.com>
To: David Laight <David.Laight@ACULAB.COM>,
Hans de Goede <firstname.lastname@example.org>,
Roger Quadros <email@example.com>,
Cc: "firstname.lastname@example.org" <email@example.com>,
"Christoph Hellwig" <firstname.lastname@example.org>,
"Rob Herring" <email@example.com>,
"Kishon Vijay Abraham I" <firstname.lastname@example.org>,
"Péter Ujfalusi" <email@example.com>
Subject: Re: [PATCH] ata: ahci_platform: add 32-bit quirk for dwc-ahci
Date: Wed, 12 Feb 2020 12:09:49 +0000 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On 2020-02-12 11:56 am, David Laight wrote:
> From: Robin Murphy
>> Sent: 12 February 2020 11:43
>> If the device *is* inherently 64-bit capable, then setting 64-bit masks
>> in the driver is correct - if a 64-bit IP block happens to have been
>> integrated with only 32 address bits wired up, but the system has memory
>> above the 32-bit boundary, then that should be described via
>> "dma-ranges", which should then end up being used to further constrain
>> the device masks internally to the DMA API.
> Given how often this happens (please can I shoot some more
> hardware engineers - he says while compiling some VHDL)
> is it possible to allocate some memory pages that are
> aliases if the address bits over 31 are ignored?
> Then (at least some) drivers could to a run-time probe
> reading to the high address and checking the data didn't
> appear in the low address.
> Only one such set of pages is needed - access can be locked.
> But they'd need to be reserved early on.
(Oh, for that much control over page allocation!)
It's a fun idea, but there's no guarantee that the platform memory map
is actually suitable (AMD Seattle is the go-to counterexample), and
having an opt-in test that every driver has to implement individually
sounds like a maintenance nightmare. I think it's far better all round
to just expect the firmware-provided machine description - be it
devicetree, ACPI, or whatever - to correctly describe the integration.
next prev parent reply other threads:[~2020-02-12 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 11:17 [PATCH] ata: ahci_platform: add 32-bit quirk for dwc-ahci Roger Quadros
2020-02-06 11:50 ` Hans de Goede
2020-02-06 11:54 ` Roger Quadros
2020-02-12 11:01 ` Roger Quadros
2020-02-12 11:32 ` Hans de Goede
2020-02-12 11:43 ` Robin Murphy
2020-02-12 11:56 ` David Laight
2020-02-12 12:09 ` Robin Murphy [this message]
2020-02-13 7:24 ` Roger Quadros
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).