From: Sudeep Dutt <sudeep.dutt@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Jim Davis <jim.epost@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Nikhil Rao <nikhil.rao@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Sudeep Dutt <sudeep.dutt@intel.com>
Subject: [PATCH char-misc-next 2/2] misc: mic: Fix reported static checker warning
Date: Tue, 9 Jun 2015 20:58:32 -0700 [thread overview]
Message-ID: <2fa7e4b829662286e3b0fc813b96596e2ce0d0de.1433896842.git.sudeep.dutt@intel.com> (raw)
In-Reply-To: <cover.1433896842.git.sudeep.dutt@intel.com>
In-Reply-To: <cover.1433896842.git.sudeep.dutt@intel.com>
Delete unnecessary prints resulting in an "spdev could be null"
warning from a static checker in scif_peer_remove(..).
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
---
drivers/misc/mic/scif/scif_main.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/misc/mic/scif/scif_main.c b/drivers/misc/mic/scif/scif_main.c
index f7187dc..6ce851f 100644
--- a/drivers/misc/mic/scif/scif_main.c
+++ b/drivers/misc/mic/scif/scif_main.c
@@ -91,8 +91,6 @@ static int scif_peer_probe(struct scif_peer_dev *spdev)
rcu_assign_pointer(scifdev->spdev, spdev);
/* In the future SCIF kernel client devices will be added here */
- dev_info(&spdev->dev, "Peer added dnode %d\n",
- spdev->dnode);
return 0;
}
@@ -109,8 +107,6 @@ static void scif_peer_remove(struct scif_peer_dev *spdev)
mutex_lock(&scif_info.conflock);
scif_info.total--;
mutex_unlock(&scif_info.conflock);
- dev_info(&spdev->dev, "Peer removed dnode %d\n",
- spdev->dnode);
}
static void scif_qp_setup_handler(struct work_struct *work)
--
1.8.2.1
prev parent reply other threads:[~2015-06-10 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 3:58 [PATCH char-misc-next 0/2] misc: mic: bug fixes Sudeep Dutt
2015-06-10 3:58 ` [PATCH char-misc-next 1/2] misc: mic: Fix randconfig build error by including errno.h Sudeep Dutt
2015-06-10 3:58 ` Sudeep Dutt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa7e4b829662286e3b0fc813b96596e2ce0d0de.1433896842.git.sudeep.dutt@intel.com \
--to=sudeep.dutt@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).