From: Matt Redfearn <matt.redfearn@mips.com>
To: Serge Semin <fancer.lancer@gmail.com>, <ralf@linux-mips.org>,
<miodrag.dinic@mips.com>, <jhogan@kernel.org>,
<goran.ferenc@mips.com>, <david.daney@cavium.com>,
<paul.gortmaker@windriver.com>, <paul.burton@mips.com>,
<alex.belits@cavium.com>, <Steven.Hill@cavium.com>
Cc: <alexander.sverdlin@nokia.com>, <kumba@gentoo.org>,
<marcin.nowakowski@mips.com>, <James.hogan@mips.com>,
<Peter.Wotton@mips.com>, <Sergey.Semin@t-platforms.ru>,
<linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/14] MIPS: memblock: Switch arch code to NO_BOOTMEM
Date: Mon, 22 Jan 2018 16:36:40 +0000 [thread overview]
Message-ID: <2fd1f530-e6c6-a528-5827-c3ecc8b4a81c@mips.com> (raw)
In-Reply-To: <20180117222312.14763-1-fancer.lancer@gmail.com>
Hi Serge,
On 17/01/18 22:22, Serge Semin wrote:
> Even though it's common to see the architecture code using both
> bootmem and memblock early memory allocators, it's not good for
> multiple reasons. First of all, it's redundant to have two
> early memory allocator while one would be more than enough from
> functionality and stability points of view. Secondly, some new
> features introduced in the kernel utilize the methods of the most
> modern allocator ignoring the older one. It means the architecture
> code must keep the both subsystems up synchronized with information
> about memory regions and reservations, which leads to the code
> complexity increase, that obviously increases bugs probability.
> Finally it's better to keep all the architectures code unified for
> better readability and code simplification. All these reasons lead
> to one conclusion - arch code should use just one memory allocator,
> which is supposed to be memblock as the most modern and already
> utilized by the most of the kernel platforms. This patchset is
> mostly about it.
>
> One more reason why the MIPS arch code should finally move to
> memblock is a BUG somewhere in the initialization process, when
> CMA is activated:
>
> [ 0.248762] BUG: Bad page state in process swapper/0 pfn:01f93
> [ 0.255415] page:8205b0ac count:0 mapcount:-127 mapping: (null) index:0x1
> [ 0.263172] flags: 0x40000000()
> [ 0.266723] page dumped because: nonzero mapcount
> [ 0.272049] Modules linked in:
> [ 0.275511] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.4.88-module #5
> [ 0.282900] Stack : 00000000 00000000 80b6dd6a 0000003a 00000000 00000000 80930000 8092bff4
> 86073a14 80ac88c7 809f21ac 00000000 00000001 80b6998c 00000400 00000000
> 80a00000 801822e8 80b6dd68 00000000 00000002 00000000 809f8024 86077ccc
> 80b80000 801e9328 809fcbc0 00000000 00000400 00010000 86077ccc 86073a14
> 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> ...
> [ 0.323148] Call Trace:
> [ 0.325935] [<8010e7c4>] show_stack+0x8c/0xa8
> [ 0.330859] [<80404814>] dump_stack+0xd4/0x110
> [ 0.335879] [<801f0bc0>] bad_page+0xfc/0x14c
> [ 0.340710] [<801f0e04>] free_pages_prepare+0x1f4/0x330
> [ 0.346632] [<801f36c4>] __free_pages_ok+0x2c/0x104
> [ 0.352154] [<80b23a40>] init_cma_reserved_pageblock+0x5c/0x74
> [ 0.358761] [<80b29390>] cma_init_reserved_areas+0x1b4/0x240
> [ 0.365170] [<8010058c>] do_one_initcall+0xe8/0x27c
> [ 0.370697] [<80b14e60>] kernel_init_freeable+0x200/0x2c4
> [ 0.376828] [<808faca4>] kernel_init+0x14/0x104
> [ 0.381939] [<80107598>] ret_from_kernel_thread+0x14/0x1c
>
> The bugus pfn seems to be the one allocated for bootmem allocator
> pages and hasn't been freed before letting the CMA working with its
> areas. Anyway the bug is solved by this patchset.
>
> Another reason why this patchset is useful is that it fixes the fdt
> reserved-memory nodes functionality for MIPS. Really it's bug to have
> the fdt reserved nodes scanning before the memblock is
> fully initialized (calling early_init_fdt_scan_reserved_mem before
> bootmem_init is called). Additionally no-map flag of the
> reserved-memory node hasn't been taking into account. This patchset
> fixes all of these.
>
> As you probably remember I already did another attempt to merge a
> similar functionality into the kernel. This time the patchset got
> to be less complex (14 patches vs 21 last time) and fixes the
> platform code like SGI IP27 and Loongson3, which due to being
> NUMA introduce its own memory initialization process. Although
> I have much doubt in SGI IP27 code operability in the first place,
> since it got prom_meminit() method of early memory initialization,
> which hasn't been called at any other place in the kernel. It must
> have been left there unrenamed after arch/mips/mips-boards/generic
> code had been discarded.
>
> Here are the list of folks, who agreed to perform some tests of
> the patchset:
> Alexander Sverdlin <alexander.sverdlin@nokia.com> - Octeon2
> Matt Redfearn <matt.redfearn@mips.com> - Loongson3, etc
I have applied and tested these patches on various platforms that we
have available here, and the kernel appears to boot and get to userspace
as normal on the following platforms:
UTM8 (Cavium Octeon III)
Creator CI20
Creator CI40
Loongson3a
MIPS Boston
MIPS Malta
MIPS SEAD3
Aside from the CONFIG_RELOCATABLE stuff, this looks pretty tidy to me.
Thanks,
Matt
> Joshua Kinard <kumba@gentoo.org> - IP27
> Marcin Nowakowski <marcin.nowakowski@mips.com>
> Thanks to you all in regards and for everybody, who will be involved
> in reviewing and testing.
>
> The patchset is applied on top of kernel 4.15-rc8 and can be found
> submitted at my repo:
> https://github.com/fancer/Linux-kernel-MIPS-memblock-project
>
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
>
> Serge Semin (14):
> MIPS: memblock: Add RESERVED_NOMAP memory flag
> MIPS: memblock: Surely map BSS kernel memory section
> MIPS: memblock: Reserve initrd memory in memblock
> MIPS: memblock: Discard bootmem initialization
> MIPS: memblock: Add reserved memory regions to memblock
> MIPS: memblock: Reserve kdump/crash regions in memblock
> MIPS: memblock: Mark present sparsemem sections
> MIPS: memblock: Simplify DMA contiguous reservation
> MIPS: memblock: Allow memblock regions resize
> MIPS: memblock: Perform early low memory test
> MIPS: memblock: Print out kernel virtual mem layout
> MIPS: memblock: Discard bootmem from Loongson3 code
> MIPS: memblock: Discard bootmem from SGI IP27 code
> MIPS: memblock: Deactivate bootmem allocator
>
> arch/mips/Kconfig | 2 +-
> arch/mips/include/asm/bootinfo.h | 1 +
> arch/mips/kernel/prom.c | 8 +-
> arch/mips/kernel/setup.c | 218 +++++++++------------
> arch/mips/loongson64/loongson-3/numa.c | 16 +-
> arch/mips/mm/init.c | 47 +++++
> arch/mips/sgi-ip27/ip27-memory.c | 9 +-
> 7 files changed, 153 insertions(+), 148 deletions(-)
>
next prev parent reply other threads:[~2018-01-22 16:41 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 22:22 [PATCH 00/14] MIPS: memblock: Switch arch code to NO_BOOTMEM Serge Semin
2018-01-17 22:22 ` [PATCH 01/14] MIPS: memblock: Add RESERVED_NOMAP memory flag Serge Semin
2018-01-17 22:23 ` [PATCH 02/14] MIPS: memblock: Surely map BSS kernel memory section Serge Semin
2018-01-22 16:35 ` Matt Redfearn
2018-01-22 21:47 ` Serge Semin
2018-01-23 11:03 ` Matt Redfearn
2018-01-23 19:27 ` Serge Semin
2018-01-24 9:49 ` Matt Redfearn
2018-01-24 10:03 ` Serge Semin
2018-01-17 22:23 ` [PATCH 03/14] MIPS: memblock: Reserve initrd memory in memblock Serge Semin
2018-01-17 22:23 ` [PATCH 04/14] MIPS: memblock: Discard bootmem initialization Serge Semin
2018-01-17 22:23 ` [PATCH 05/14] MIPS: memblock: Add reserved memory regions to memblock Serge Semin
2018-01-17 22:23 ` [PATCH 06/14] MIPS: memblock: Reserve kdump/crash regions in memblock Serge Semin
2018-01-17 22:23 ` [PATCH 07/14] MIPS: memblock: Mark present sparsemem sections Serge Semin
2018-01-24 6:13 ` Marcin Nowakowski
2018-01-24 7:27 ` Serge Semin
2018-01-17 22:23 ` [PATCH 08/14] MIPS: memblock: Simplify DMA contiguous reservation Serge Semin
2018-01-17 22:23 ` [PATCH 09/14] MIPS: memblock: Allow memblock regions resize Serge Semin
2018-01-17 22:23 ` [PATCH 10/14] MIPS: memblock: Perform early low memory test Serge Semin
2018-01-17 22:23 ` [PATCH 11/14] MIPS: memblock: Print out kernel virtual mem layout Serge Semin
2018-01-18 20:03 ` Florian Fainelli
2018-01-18 20:18 ` Serge Semin
2018-01-19 7:59 ` Matt Redfearn
2018-01-19 14:27 ` Serge Semin
2018-01-23 15:35 ` Matt Redfearn
2018-01-23 19:10 ` Serge Semin
2018-01-24 9:46 ` Matt Redfearn
2018-01-24 10:08 ` Serge Semin
2018-01-17 22:23 ` [PATCH 12/14] MIPS: memblock: Discard bootmem from Loongson3 code Serge Semin
2018-01-23 22:28 ` Jiaxun Yang
2018-01-23 19:36 ` Serge Semin
2018-01-17 22:23 ` [PATCH 13/14] MIPS: memblock: Discard bootmem from SGI IP27 code Serge Semin
2018-01-17 22:23 ` [PATCH 14/14] MIPS: memblock: Deactivate bootmem allocator Serge Semin
2018-01-23 23:59 ` James Hogan
2018-01-24 8:28 ` Serge Semin
2018-01-22 16:36 ` Matt Redfearn [this message]
2018-01-22 21:33 ` [PATCH 00/14] MIPS: memblock: Switch arch code to NO_BOOTMEM Serge Semin
2018-01-23 11:29 ` Mathieu Malaterre
2018-01-23 14:01 ` Matt Redfearn
2018-01-25 17:58 ` Alexander Sverdlin
2018-01-25 20:17 ` Serge Semin
2018-01-31 0:21 ` Serge Semin
2018-02-02 3:54 ` [PATCH v2 00/15] " Serge Semin
2018-02-02 3:54 ` [PATCH v2 01/15] MIPS: memblock: Add RESERVED_NOMAP memory flag Serge Semin
2018-02-13 11:21 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 02/15] MIPS: memblock: Surely map BSS kernel memory section Serge Semin
2018-02-13 11:22 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 03/15] MIPS: memblock: Reserve initrd memory in memblock Serge Semin
2018-02-13 11:22 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 04/15] MIPS: memblock: Discard bootmem initialization Serge Semin
2018-02-13 11:28 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 05/15] MIPS: KASLR: Drop relocatable fixup from reservation_init Serge Semin
2018-02-13 11:30 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 06/15] MIPS: memblock: Add reserved memory regions to memblock Serge Semin
2018-02-13 13:44 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 07/15] MIPS: memblock: Reserve kdump/crash regions in memblock Serge Semin
2018-02-13 13:45 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 08/15] MIPS: memblock: Mark present sparsemem sections Serge Semin
2018-02-13 13:50 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 09/15] MIPS: memblock: Simplify DMA contiguous reservation Serge Semin
2018-02-13 13:51 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 10/15] MIPS: memblock: Allow memblock regions resize Serge Semin
2018-02-13 13:55 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 11/15] MIPS: memblock: Perform early low memory test Serge Semin
2018-02-13 14:01 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 12/15] MIPS: memblock: Print out kernel virtual mem layout Serge Semin
2018-02-13 14:05 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 13/15] MIPS: memblock: Discard bootmem from Loongson3 code Serge Semin
2018-02-13 14:09 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 14/15] MIPS: memblock: Discard bootmem from SGI IP27 code Serge Semin
2018-02-13 14:17 ` Matt Redfearn
2018-02-02 3:54 ` [PATCH v2 15/15] MIPS: memblock: Deactivate bootmem allocator Serge Semin
2018-02-13 14:18 ` Matt Redfearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fd1f530-e6c6-a528-5827-c3ecc8b4a81c@mips.com \
--to=matt.redfearn@mips.com \
--cc=James.hogan@mips.com \
--cc=Peter.Wotton@mips.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=Steven.Hill@cavium.com \
--cc=alex.belits@cavium.com \
--cc=alexander.sverdlin@nokia.com \
--cc=david.daney@cavium.com \
--cc=fancer.lancer@gmail.com \
--cc=goran.ferenc@mips.com \
--cc=jhogan@kernel.org \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marcin.nowakowski@mips.com \
--cc=miodrag.dinic@mips.com \
--cc=paul.burton@mips.com \
--cc=paul.gortmaker@windriver.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).