From: Joe Perches <joe@perches.com>
To: "niklas.soderlund@corigine.com" <niklas.soderlund@corigine.com>,
Philippe Schenker <philippe.schenker@toradex.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
"apw@canonical.com" <apw@canonical.com>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"louis.peens@corigine.com" <louis.peens@corigine.com>,
"simon.horman@corigine.com" <simon.horman@corigine.com>,
"oss-drivers@corigine.com" <oss-drivers@corigine.com>
Subject: Re: [PATCH v4] checkpatch: warn for non-standard fixes tag style
Date: Sat, 10 Sep 2022 19:47:57 -0700 [thread overview]
Message-ID: <2febb7893346b6234983453de7c037536e479bfc.camel@perches.com> (raw)
In-Reply-To: <9f9a0740aef282d30af8fa02ca7c6479e80aa9a0.camel@perches.com>
On Fri, 2022-09-09 at 10:57 -0700, Joe Perches wrote:
> On Fri, 2022-09-09 at 09:40 +0200, niklas.soderlund@corigine.com wrote:
> > On 2022-09-08 17:49:14 +0000, Philippe Schenker wrote:
[]
> > > I would check all lines that start with fixes, even if there is
> > > whitespace in front (and then failing later on...)
> > >
> > > if (!$in_header_lines && $line =~ /^\s*fixes:?/i) {
>
> I think that's a poor idea.
>
> You should really review git history for lines that start with fixes
> and look at the number of false positives that would give.
>
> Try this grep:
>
> $ git log -100000 --no-merges --grep="^\s*fixes" -i --format=email -P | \
> grep -P -i "^\s*fixes)" | \
> grep -P -v "^Fixes: [0-9a-f]{12,}'
> [...]
>
> That is a greater than 10% false positive rate.
One day I'll be better at typing grep commands in the editor...
Try:
$ git log -100000 --no-merges --grep="^\s*fixes" -i --format=email -P | \
grep -P -i "^\s*fixes" | \
grep -P -v "^Fixes: [0-9a-f]{12,}"
prev parent reply other threads:[~2022-09-11 2:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 16:44 [PATCH v4] checkpatch: warn for non-standard fixes tag style Niklas Söderlund
2022-09-08 17:49 ` Philippe Schenker
2022-09-09 7:40 ` niklas.soderlund
2022-09-09 14:39 ` Philippe Schenker
2022-09-09 17:57 ` Joe Perches
2022-09-10 8:48 ` niklas.soderlund
2022-09-11 2:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2febb7893346b6234983453de7c037536e479bfc.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=lukas.bulwahn@gmail.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=philippe.schenker@toradex.com \
--cc=sfr@canb.auug.org.au \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).