From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Hulk Robot <hulkci@huawei.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] nvmem: Fix return value check in rmem_read()
Date: Tue, 23 Feb 2021 15:55:29 +0100 [thread overview]
Message-ID: <2fff7c82d983baccb91c4a1c0891a9b6cdc50dd6.camel@suse.de> (raw)
In-Reply-To: <20210223142214.3405217-1-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Tue, 2021-02-23 at 14:22 +0000, Wei Yongjun wrote:
> In case of error, the function memremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Fixes: 5a3fa75a4d9c ("nvmem: Add driver to expose reserved memory as nvmem")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Thanks!
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-02-23 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:22 [PATCH -next] nvmem: Fix return value check in rmem_read() Wei Yongjun
2021-02-23 14:55 ` Nicolas Saenz Julienne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fff7c82d983baccb91c4a1c0891a9b6cdc50dd6.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).