From: Julien Stephan <jstephan@baylibre.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: mkorpershoek@baylibre.com, khilman@baylibre.com,
Florian Sylvestre <fsylvestre@baylibre.com>,
Andy Hsieh <andy.hsieh@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v3 2/3] dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5
Date: Wed, 24 May 2023 16:05:03 +0200 [thread overview]
Message-ID: <2jfgupyvtuenvm7x52l6bo5xzzpva7u6njeg3ecd52wwj4spv6@y3nsq7j2hl2u> (raw)
In-Reply-To: <f92c39c8-177a-e18d-c3b0-79e7349ea4db@collabora.com>
On Wed, May 24, 2023 at 11:45:30AM +0200, AngeloGioacchino Del Regno wrote:
> Il 24/05/23 10:30, Julien Stephan ha scritto:
> > From: Florian Sylvestre <fsylvestre@baylibre.com>
> >
> > This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in
> > some Mediatek soc, such as the mt8365
> >
> > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
> > Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> > ---
> > .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 67 +++++++++++++++++++
> > MAINTAINERS | 6 ++
> > 2 files changed, 73 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
> > new file mode 100644
> > index 000000000000..a1bd96a98051
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
> > @@ -0,0 +1,67 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (c) 2023 MediaTek, BayLibre
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/mediatek,mt8365-csi-rx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek Sensor Interface MIPI CSI CD-PHY
> > +
> > +maintainers:
> > + - Julien Stephan <jstephan@baylibre.com>
> > + - Andy Hsieh <andy.hsieh@mediatek.com>
> > +
> > +description:
> > + The SENINF CD-PHY is a set of CD-PHY connected to the SENINF CSI-2
> > + receivers. The number of PHYs depends on the SoC model.
> > + Depending on the SoC model, each PHYs can be either CD-PHY or D-PHY only
> > + capable.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8365-csi-rx
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#phy-cells':
> > + const: 0
> > +
> > + mediatek,phy-type:
>
> Instead of declaring a phy-type here like this, can't we instead declare that in
> the phy cells, like we're doing with MTK TPHY and like other non-MediaTek PHYs are
> already doing?
>
> device {
> ...
> phys = <&csi0_rx PHY_TYPE_CDPHY>;
> ...
> }
>
> Regards,
> Angelo
>
>
Hi Angelo,
This is a hardware property that is not dynamic, so IMHO it doesn't make sense
to use phy argument for that. Some driver already use a 'phy-type'
property (such as phy-cadence-torrent.yaml).
I was thinking of using phy argument on future upgrade when driver will
support D-PHY and C-PHY modes so the phy user will be able to choose the
mode.
Does it makes sense?
Best
Julien
next prev parent reply other threads:[~2023-05-24 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 8:30 [PATCH v3 0/3] phy: mtk-mipi-csi: add driver for CSI phy Julien Stephan
2023-05-24 8:30 ` [PATCH v3 1/3] dt-bindings: phy: add PHY_TYPE_CDPHY definition Julien Stephan
2023-05-24 9:45 ` AngeloGioacchino Del Regno
2023-06-03 19:09 ` Krzysztof Kozlowski
2023-05-24 8:30 ` [PATCH v3 2/3] dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5 Julien Stephan
2023-05-24 9:45 ` AngeloGioacchino Del Regno
2023-05-24 14:05 ` Julien Stephan [this message]
2023-06-08 20:05 ` Rob Herring
2023-05-24 8:30 ` [PATCH v3 3/3] phy: mtk-mipi-csi: add driver for CSI phy Julien Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2jfgupyvtuenvm7x52l6bo5xzzpva7u6njeg3ecd52wwj4spv6@y3nsq7j2hl2u \
--to=jstephan@baylibre.com \
--cc=andy.hsieh@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fsylvestre@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).