From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932582AbdCIO6H (ORCPT ); Thu, 9 Mar 2017 09:58:07 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:37411 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862AbdCIO6C (ORCPT ); Thu, 9 Mar 2017 09:58:02 -0500 X-AuditID: b6c32a2c-f79b56d0000012f0-50-58c16d69564e From: Bartlomiej Zolnierkiewicz To: Russell King - ARM Linux Cc: Sergei Shtylyov , Sekhar Nori , Arnd Bergmann , Dmitry Eremin-Solenikov , Kevin Hilman , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Date: Thu, 09 Mar 2017 15:57:37 +0100 Message-id: <3001681.2O13sqAj0p@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170309145147.GL21222@n2100.armlinux.org.uk> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA02Sb0hTYRTGee/ddu+Gq9s0PSolDQoUm05UrhmpkHD7A/ophhA18qKm07E7 RUVSgloIkzmRaprtg1asNJumpub/VEpDU9SEZphJaiE6V+qQcl4Dv/3OeZ/zvOd5eUlcZhcG kBnZelaXrc6SiySClv7gkNMZml5V+O/REHrHPEjQ5oVVnN4yNGO0/duUkB5sm8foifZqEd1X +RbR3cZGjH4/7RTRI7ZZIl7CTEyN44x724yY1Zk7BPO18i/GvLF8IZim2mJmcvi2kBmaacUY p/14sjhFcjaVzcrIY3Vh565L0hcfPhNo66n8sZYfRAma9CpFYhKoSJj/1S/i2RfGHC93WULK qDoEna4Wgi8MGEy/cuCliNybWJwt5vvVCKqdZQK+cCF41/EY81iJqDNQbrAhD/vsDgz2bgg8 jFOfMKg2J3qMvKkL0Lgd6kEBdRI+VMV5FFIqGJbqloQePkpdhOYuw56jmIqFuSfPhbzmCGxW OPYdg6Cru1LIcyiMDjYgzzpAOQhYNxmF/M7HwN6D8yHPw8BP3hMob1geaiZ4DoSdulnE830E rW7gfZoQ2DpM+6JY6B8a37/sEBjdCxjvL4V7d2W8hIF297yAbyfAqk3Pv84KAlNDFWFCQZYD ESwHIlgORLAi3IZ8WS2nSWO5KK1Swak1XG52muJGjsaO9n5SSGgbclgv9SGKRHIv6YO4HpVM qM7jCjR9CEhc7iM9cbNXJZOmqgsKWV3ONV1uFsv1oUBSIPeTpoSXq2RUmlrPZrKsltX9P8VI cUAJYiM7ccXA66il4RZF/q2ZpyWFYRUZf2IaU07F1yZN+a9H49l5Ma4V7WfjhlLfsWk2rRGU /qoxJcLKZI7gyu8JtbKi0Mv1pHluzJroE2HYkjlGymr8lWvm5AGLP1cvue16pEuiK5ll57pf t+vwwnLRx8WtaLHiyuqLqpqBCLmAS1crQ3Adp/4Hph1qdUUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t9jQd3M3IMRBjOaxSz+TjrGbjHpyXtm i5/tW5gsNj2+xmpxbMcjJovLu+awWRyaupfRYn/vBiaLU9c/s1mcWXWL3YHL4/K1i8wev39N YvR4f6OV3ePB1P9MHjtn3WX32Lyk3uPKiSZWj+M3tjN5fN4kF8AZ5WaTkZqYklqkkJqXnJ+S mZduqxQa4qZroaSQl5ibaqsUoesbEqSkUJaYUwrkGRmgAQfnAPdgJX27BLeMZzNXsBSsFai4 sO0FewPjFZ4uRg4OCQETiWe36rsYOYFMMYkL99azdTFycQgJzGKUuHjsMxOE85VRou/JFGaQ KjYBK4mJ7asYQWwRoOZjB7+wgBQxC1xhkpi1fCUTyFRhAU+JDb90QEwWAVWJ07PtQcp5BTQl Xi59yQpiiwp4SWzZ184EYnMKWEvcX7aaFWLXdEaJe8dOsEA0CEr8mHwPzGYWkJfYt38qK4St JbF+53GmCYxAZyKUzUJSNgtJ2QJG5lWMEqkFyQXFSem5Rnmp5XrFibnFpXnpesn5uZsYwXH6 THoH4+Fd7ocYBTgYlXh4BYQPRAixJpYVV+YeYpTgYFYS4VXMOhghxJuSWFmVWpQfX1Sak1p8 iNEU6MGJzFKiyfnAFJJXEm9oYm5ibmxgYW5paWKkJM7bOPtZuJBAemJJanZqakFqEUwfEwen VAOjdGjPpbUTNsXktDmdW2mn8l3a+83lRy1Won9Vv258VaWe+uAi+2LlWc0yLn98zVq/luyZ Gfvwxje/wE97N5ZEvNXT1nPzUXg+Z54FG9MtvgI/mfB4l2vdWzQqXj96dyB3V52Rc59u4cwf UheX63k+6EzLXnogovTSCcWfjm3h39Ntoo+nTzmlxFKckWioxVxUnAgAfexf4OkCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170309145745epcas5p331cf5418a586b8d435a508626cbf7af9 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170309145745epcas5p331cf5418a586b8d435a508626cbf7af9 X-RootMTR: 20170309145745epcas5p331cf5418a586b8d435a508626cbf7af9 References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <3285453.g1rFzTv5DW@amdc3058> <20170309145147.GL21222@n2100.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, March 09, 2017 02:51:47 PM Russell King - ARM Linux wrote: > On Thu, Mar 09, 2017 at 03:42:49PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Thursday, March 09, 2017 01:57:15 PM Russell King - ARM Linux wrote: > > > On Thu, Mar 09, 2017 at 03:24:56PM +0300, Sergei Shtylyov wrote: > > > > On 03/09/2017 03:20 PM, Sekhar Nori wrote: > > > > > > > > >[...] > > > > > > > > >>>diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c > > > > >>>b/arch/arm/mach-davinci/board-dm644x-evm.c > > > > >>>index 023480b75244..60a1f23890cd 100644 > > > > >>>--- a/arch/arm/mach-davinci/board-dm644x-evm.c > > > > >>>+++ b/arch/arm/mach-davinci/board-dm644x-evm.c > > > > >>>@@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device > > > > >>>*phydev) > > > > >>> return 0; > > > > >>> } > > > > >>> > > > > >>>-#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > > > > >>>+#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) > > > > >> > > > > >> I think it would be more correct to check for both libata and IDE > > > > >>drivers here... > > > > > > > > > >As I understand, the plan is to remove the IDE driver soon. > > > > > > > > I'm not sure DaveM would support any removals in drivers/ide/. He has > > > > explicitly expressed his will to maintain the IDE driuver forever. > > > > > > As I keep saying, there are ARM machines where the IDE driver works but > > > the PATA driver doesn't. EBSA110's PCMCIA slots for instance. > > > > Please be more specific, I'll be happy to help with migrating this > > machines to libata PATA. > > > > BTW the example you're giving has never worked with the old IDE > > driver in the upstream kernel. > > That's where you are wrong. It worked for 10+ years with no > modifications in the upstream IDE driver or ide-cs driver - only the > patch I quoted was required. ..and the patch you quoted is in which upstream kernel version exactly? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics