From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Kees Cook <keescook@chromium.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc
Date: Thu, 18 Mar 2021 07:55:35 -0400 [thread overview]
Message-ID: <300176.1616068535@turing-police> (raw)
In-Reply-To: <279b22592f1e43a48beeecd34e50b385@AcuMS.aculab.com>
[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]
On Thu, 18 Mar 2021 11:41:29 -0000, David Laight said:
> That gcc bug just implies you need a space after "xxx".
> That is easily fixable in the sources.
It's not quite that simple.
In file included from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/tm.h:27,
from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/gcc-plugin.h:31,
from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/plugin.h:23,
from scripts/gcc-plugins/gcc-common.h:9,
from scripts/gcc-plugins/latent_entropy_plugin.c:78:
>> /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\
The problem isn't in a kernel source file... To quote an earlier message of mine:
> It looks like it's not a kernel source tree issue, it's a g++ issue fixed in g++ 6 and later.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69959
> And it looks like there was an intent to backport it to 4.9 and 5.4:
> https://gcc.gnu.org/legacy-ml/gcc-patches/2016-02/msg01409.html
> The bugtracker doesn't show an equivalent for 69959 being closed against 4.9.x or 5.[56],
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63254 has a patch for one of the
> gcc-supplied files that tosses the warning, but that way lies madness...
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-03-18 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 8:40 [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc Valdis Klētnieks
2021-03-18 5:52 ` Kees Cook
2021-03-18 6:02 ` Valdis Klētnieks
2021-03-18 6:26 ` Miguel Ojeda
2021-03-18 9:07 ` Masahiro Yamada
2021-03-18 11:47 ` Valdis Klētnieks
2021-03-18 11:41 ` David Laight
2021-03-18 11:55 ` Valdis Klētnieks [this message]
2021-03-18 13:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=300176.1616068535@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=David.Laight@ACULAB.COM \
--cc=geert@linux-m68k.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).