linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Steven Cole <elenstev@mesatop.com>, Val Henson <val@nmt.edu>
Cc: Dave Jones <davej@codemonkey.org.uk>,
	Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: Those ruddy punctuation fixes
Date: Thu, 06 Mar 2003 19:33:33 -0800	[thread overview]
Message-ID: <300890000.1047008011@[10.10.2.4]> (raw)
In-Reply-To: <1047005054.4114.99.camel@spc1.mesatop.com>

>> Wait, this sounds like a conversation with the Mafia:
>> 
>> "Pay us protection money."
>> "Why do we need to pay you for protection?"
>> "So we can protect you from criminals like ourselves."
> 
> That's a ridiculous comparison and it weakens your argument.  Leaving a

Reductio ad absurdum is often enlightening.

> potential problem in place rather than fixing it as I did would be the
> passive-aggressive approach, not the other way around.

But that's not exactly what you're doing - you're replacing one 
(very small) problem with another (very real) problem, the breakage 
of people's patches. Fixing up patches because of spelling
errors is a total waste of developer's time.

>> I'd rather solve this problem by making standalone spelling fixes and
>> other cosmetic changes taboo.  Cosmetic changes combined with actual
>> useful code changes are fine with me.  If you're risking breaking the
>> build, there should be some benefit that justifies the risk.
> 
> Breaking the build is a low probability (many hundreds of fixes and one 
> build break AFAIK) and low consequence failure (a build fix of that
> nature is obvious and quickly and easily done).

Breaking the build is indeed a low probability (assuming you compile
test your tree). Breaking other people's patches is a high probablility.

M.

  reply	other threads:[~2003-03-07  3:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-05 11:10 Those ruddy punctuation fixes Russell King
2003-03-05 11:22 ` John Bradford
2003-03-05 14:18   ` Mike Dresser
2003-03-06  1:50   ` jw schultz
2003-03-06  9:58     ` Russell King
2003-03-06 10:46     ` John Bradford
2003-03-05 12:20 ` Dave Jones
2003-03-05 11:37   ` good info on memory management Prasad Kamath
2003-03-05 12:03     ` Terje Eggestad
2003-03-06  8:16       ` Ranjeet Shetye
2003-03-06  3:11   ` Those ruddy punctuation fixes Steven Cole
2003-03-07  1:04     ` Val Henson
2003-03-07  2:44       ` Steven Cole
2003-03-07  3:33         ` Martin J. Bligh [this message]
2003-03-07  4:02           ` Steven Cole
2003-03-07  5:11             ` Martin J. Bligh
2003-03-07 17:04             ` Hans Reiser
     [not found]     ` <mailman.1047000901.5238.linux-kernel2news@redhat.com>
2003-03-07  3:07       ` Pete Zaitcev
2003-03-07  7:16 Dan Kegel
2003-03-07 17:17 ` Benjamin LaHaise
2003-03-07 18:00   ` Dan Kegel
2003-03-07 23:15   ` Alan Cox
2003-03-08  0:52     ` Dave Jones
2003-03-08  0:04       ` Randy.Dunlap
2003-03-08  0:29       ` Werner Almesberger
2003-03-08  1:09         ` Dan Kegel
2003-03-08  2:18           ` Werner Almesberger
2003-03-08  1:08       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='300890000.1047008011@[10.10.2.4]' \
    --to=mbligh@aracnet.com \
    --cc=davej@codemonkey.org.uk \
    --cc=elenstev@mesatop.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=val@nmt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).