From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E476FC04A6B for ; Mon, 6 May 2019 19:21:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAAC9206BF for ; Mon, 6 May 2019 19:21:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="ao1+ooO/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbfEFTVE (ORCPT ); Mon, 6 May 2019 15:21:04 -0400 Received: from dc2-smtprelay2.synopsys.com ([198.182.61.142]:56526 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726296AbfEFTVE (ORCPT ); Mon, 6 May 2019 15:21:04 -0400 Received: from mailhost.synopsys.com (dc2-mailhost2.synopsys.com [10.12.135.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 29852C01CD; Mon, 6 May 2019 19:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1557170458; bh=mP7HLQL4LwG7nlP79tbHYPORo2cfL2im4AizGlVx5ys=; h=From:To:CC:Subject:Date:References:From; b=ao1+ooO/XUL4uuPc9CotDonkfdHGZCtX3xBOMDLIceYD4oXWKYfa0+iHAXskJ5msY JxgADvLYr/onKhESSu7b5RBD15Qy1VCJ+yeRGACSShzS/HJVsjNsq5w3mA/Mv9if4J 7fntC4uunXAbs23GjEsR8LnSdDDqHtj+stfU/hus7aBr7Qdcs8wbPsUZCUvXLomA6Y ACgJ2PrHe/dnjX0XQ4Ky4gxIkRfn4M06w+Us7O7r72Nha9kkJe+M+OK1xCOCLpz4m/ c+ty/bAvogQc645Wzwd8kq+zMZ7YKbzO8DFncVlymsZPxntMekZ03bZPuY+oBpfNPX bYqYxY1+YFFbA== Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 3EE4CA0095; Mon, 6 May 2019 19:21:03 +0000 (UTC) Received: from us01wembx1.internal.synopsys.com ([169.254.1.223]) by US01WXQAHTC1.internal.synopsys.com ([::1]) with mapi id 14.03.0415.000; Mon, 6 May 2019 12:21:03 -0700 From: Thinh Nguyen To: Anurag Kumar Vulisha , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Felipe Balbi CC: "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "v.anuragkumar@gmail.com" Subject: Re: [PATCH 3/3] usb: dwc3: gadget: Add support for disabling U1 and U2 entries Thread-Topic: [PATCH 3/3] usb: dwc3: gadget: Add support for disabling U1 and U2 entries Thread-Index: AQHVANC7IojVFwqibkuorQOh5WYjBw== Date: Mon, 6 May 2019 19:21:02 +0000 Message-ID: <30102591E157244384E984126FC3CB4F639E7BA8@us01wembx1.internal.synopsys.com> References: <1556792423-4833-1-git-send-email-anurag.kumar.vulisha@xilinx.com> <1556792423-4833-4-git-send-email-anurag.kumar.vulisha@xilinx.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.13.184.19] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anurag,=0A= =0A= Anurag Kumar Vulisha wrote:=0A= > Gadget applications may have a requirement to disable the U1 and U2=0A= > entry based on the usecase. For example, when performing performance=0A= > benchmarking on mass storage gadget the U1 and U2 entries can be disabled= .=0A= > Another example is when periodic transfers like ISOC transfers are used= =0A= > with bInterval of 1 which doesn't require the link to enter into U1 or U2= =0A= > state (since ping is issued from host for every uframe interval). In this= =0A= > case the U1 and U2 entry can be disabled. This can be done by setting=0A= > U1DevExitLat and U2DevExitLat values to 0 in the BOS descriptor. Host on= =0A= > seeing 0 value for U1DevExitLat and U2DevExitLat, it doesn't send SET_SEL= =0A= > commands to the gadget. Thus entry of U1 and U2 states can be avioded.=0A= > This patch updates the same=0A= =0A= I don't think we should assume that's the case for every host driver.=0A= =0A= >=0A= > Signed-off-by: Anurag Kumar Vulisha =0A= > ---=0A= > drivers/usb/dwc3/core.c | 4 ++++=0A= > drivers/usb/dwc3/core.h | 4 ++++=0A= > drivers/usb/dwc3/gadget.c | 19 +++++++++++++++++++=0A= > drivers/usb/dwc3/gadget.h | 6 ++++++=0A= > 4 files changed, 33 insertions(+)=0A= >=0A= > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c=0A= > index a1b126f..4f0912c 100644=0A= > --- a/drivers/usb/dwc3/core.c=0A= > +++ b/drivers/usb/dwc3/core.c=0A= > @@ -1285,6 +1285,10 @@ static void dwc3_get_properties(struct dwc3 *dwc)= =0A= > "snps,dis_u2_susphy_quirk");=0A= > dwc->dis_enblslpm_quirk =3D device_property_read_bool(dev,=0A= > "snps,dis_enblslpm_quirk");=0A= > + dwc->dis_u1_entry_quirk =3D device_property_read_bool(dev,=0A= > + "snps,dis_u1_entry_quirk");=0A= > + dwc->dis_u2_entry_quirk =3D device_property_read_bool(dev,=0A= > + "snps,dis_u2_entry_quirk");=0A= =0A= Please use "-" rather than "_" in the property names.=0A= =0A= > dwc->dis_rxdet_inp3_quirk =3D device_property_read_bool(dev,=0A= > "snps,dis_rxdet_inp3_quirk");=0A= > dwc->dis_u2_freeclk_exists_quirk =3D device_property_read_bool(dev,=0A= > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h=0A= > index 1528d39..fa398e2 100644=0A= > --- a/drivers/usb/dwc3/core.h=0A= > +++ b/drivers/usb/dwc3/core.h=0A= > @@ -1015,6 +1015,8 @@ struct dwc3_scratchpad_array {=0A= > * @dis_u2_susphy_quirk: set if we disable usb2 suspend phy=0A= > * @dis_enblslpm_quirk: set if we clear enblslpm in GUSB2PHYCFG,=0A= > * disabling the suspend signal to the PHY.=0A= > + * @dis_u1_entry_quirk: set if link entering into U1 state needs to be d= isabled.=0A= > + * @dis_u2_entry_quirk: set if link entering into U2 state needs to be d= isabled.=0A= > * @dis_rxdet_inp3_quirk: set if we disable Rx.Detect in P3=0A= > * @dis_u2_freeclk_exists_quirk : set if we clear u2_freeclk_exists=0A= > * in GUSB2PHYCFG, specify that USB2 PHY doesn't=0A= > @@ -1206,6 +1208,8 @@ struct dwc3 {=0A= > unsigned dis_u3_susphy_quirk:1;=0A= > unsigned dis_u2_susphy_quirk:1;=0A= > unsigned dis_enblslpm_quirk:1;=0A= > + unsigned dis_u1_entry_quirk:1;=0A= > + unsigned dis_u2_entry_quirk:1;=0A= > unsigned dis_rxdet_inp3_quirk:1;=0A= > unsigned dis_u2_freeclk_exists_quirk:1;=0A= > unsigned dis_del_phy_power_chg_quirk:1;=0A= > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c=0A= > index e293400..f2d3112 100644=0A= > --- a/drivers/usb/dwc3/gadget.c=0A= > +++ b/drivers/usb/dwc3/gadget.c=0A= > @@ -2073,6 +2073,24 @@ static int dwc3_gadget_stop(struct usb_gadget *g)= =0A= > return 0;=0A= > }=0A= > =0A= > +static void dwc3_gadget_config_params(struct usb_gadget *g,=0A= > + struct usb_dcd_config_params *params)=0A= > +{=0A= > + struct dwc3 *dwc =3D gadget_to_dwc(g);=0A= > +=0A= > + /* U1 Device exit Latency */=0A= > + if (dwc->dis_u1_entry_quirk)=0A= > + params->bU1devExitLat =3D 0;=0A= > + else=0A= > + params->bU1devExitLat =3D DWC3_DEFAULT_U1_DEV_EXIT_LAT;=0A= > +=0A= > + /* U2 Device exit Latency */=0A= > + if (dwc->dis_u2_entry_quirk)=0A= > + params->bU2DevExitLat =3D 0;=0A= > + else=0A= > + params->bU2DevExitLat =3D DWC3_DEFAULT_U2_DEV_EXIT_LAT;=0A= > +}=0A= > +=0A= > static void dwc3_gadget_set_speed(struct usb_gadget *g,=0A= > enum usb_device_speed speed)=0A= > {=0A= > @@ -2142,6 +2160,7 @@ static const struct usb_gadget_ops dwc3_gadget_ops = =3D {=0A= > .udc_start =3D dwc3_gadget_start,=0A= > .udc_stop =3D dwc3_gadget_stop,=0A= > .udc_set_speed =3D dwc3_gadget_set_speed,=0A= > + .get_config_params =3D dwc3_gadget_config_params,=0A= > };=0A= > =0A= > /* ---------------------------------------------------------------------= ----- */=0A= > diff --git a/drivers/usb/dwc3/gadget.h b/drivers/usb/dwc3/gadget.h=0A= > index 3ed738e..5faf4d1 100644=0A= > --- a/drivers/usb/dwc3/gadget.h=0A= > +++ b/drivers/usb/dwc3/gadget.h=0A= > @@ -48,6 +48,12 @@ struct dwc3;=0A= > /* DEPXFERCFG parameter 0 */=0A= > #define DWC3_DEPXFERCFG_NUM_XFER_RES(n) ((n) & 0xffff)=0A= > =0A= > +/* U1 Device exit Latency */=0A= > +#define DWC3_DEFAULT_U1_DEV_EXIT_LAT 0x0A /* Less then 10 microsec */=0A= > +=0A= > +/* U2 Device exit Latency */=0A= > +#define DWC3_DEFAULT_U2_DEV_EXIT_LAT 0x1FF /* Less then 511 microsec */= =0A= > +=0A= > /* ---------------------------------------------------------------------= ----- */=0A= > =0A= > #define to_dwc3_request(r) (container_of(r, struct dwc3_request, request= ))=0A= =0A= Setting the exit latency for U1/U2 to 0 to prevent U1/U2 entry looks=0A= more like a workaround than actually disabling U1/U2. There are=0A= DCTL.INITU1/2ENA and DCTL.ACCEPTU1/2ENA for that.=0A= =0A= Also, if these properties are set, then the device should rejects=0A= SET_FEATURE(U1/U2) requests.=0A= =0A= You can review Felipe's little code snippet from here to disable U1/U2:=0A= https://marc.info/?l=3Dlinux-usb&m=3D155419284426942&w=3D2=0A= =0A= BR,=0A= Thinh=0A=