From: Jim Wright <wrightj@linux.vnet.ibm.com>
To: Rob Herring <robh@kernel.org>
Cc: jdelvare@suse.com, linux@roeck-us.net, mark.rutland@arm.com,
corbet@lwn.net, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jim Wright <jlwright@us.ibm.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon/pmbus: Add UCD90320 power sequencer
Date: Wed, 4 Dec 2019 17:32:49 -0600 [thread overview]
Message-ID: <30187513-85f1-7336-32eb-fc0b19d6b093@linux.vnet.ibm.com> (raw)
In-Reply-To: <20191204225901.GA20804@bogus>
Hi Rob,
On 12/4/2019 4:59 PM, Rob Herring wrote:
> On Fri, Nov 22, 2019 at 04:25:41PM -0600, Jim Wright wrote:
>> From: Jim Wright <jlwright@us.ibm.com>
>>
>> Document the UCD90320 device tree binding.
>>
>> Signed-off-by: Jim Wright <jlwright@us.ibm.com>
>> ---
>> .../devicetree/bindings/hwmon/pmbus/ucd90320.txt | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
> Can you make this a schema. See
> Documentation/devicetree/writing-schema.rst.
Ok, will do and submit patch set revision.
Thanks for the review,
Jim Wright
>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
>> new file mode 100644
>> index 000000000000..e1c1057c6292
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
>> @@ -0,0 +1,13 @@
>> +UCD90320 power sequencer
>> +-------------------------
>> +
>> +Requires node properties:
>> +- compatible : "ti,ucd90320"
>> +- reg : the I2C address of the device. This is 0x11, 0x13, 0x17, 0x31, 0x33,
>> + 0x37, 0x71, 0x73, or 0x77.
>> +
>> +Example:
>> + ucd90320@11 {
>> + compatible = "ti,ucd90320";
>> + reg = <0x11>;
>> + };
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2019-12-04 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 22:25 [PATCH 0/2] hwmon: Add UCD90320 power sequencer chip Jim Wright
2019-11-22 22:25 ` [PATCH 1/2] dt-bindings: hwmon/pmbus: Add UCD90320 power sequencer Jim Wright
2019-12-04 22:59 ` Rob Herring
2019-12-04 23:32 ` Jim Wright [this message]
2019-11-22 22:25 ` [PATCH 2/2] hwmon: Add support for UCD90320 Power Sequencer Jim Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30187513-85f1-7336-32eb-fc0b19d6b093@linux.vnet.ibm.com \
--to=wrightj@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jlwright@us.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).