From: Mukesh Ojha <mojha@codeaurora.org>
To: Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Query on shrink list
Date: Fri, 17 Aug 2018 15:39:22 +0530 [thread overview]
Message-ID: <301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org> (raw)
Hi Al Viro,
Is there is reason we have kept data->found++, if the dentry already
there in shrink list ?
static enum d_walk_ret select_collect(
...
if (dentry->d_flags & DCACHE_SHRINK_LIST) {
data->found++;
} else {
..
If the dentry is already there on shrink list, does it not mean that
data->found is already non-zero ?
Can't we just go out from here directly?
Regards,
Mukesh
next reply other threads:[~2018-08-17 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 10:09 Mukesh Ojha [this message]
2018-08-17 12:58 ` Query on shrink list Al Viro
2018-08-17 14:37 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).