From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C81C43441 for ; Wed, 28 Nov 2018 13:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E375720832 for ; Wed, 28 Nov 2018 13:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E375720832 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728518AbeK2Asz (ORCPT ); Wed, 28 Nov 2018 19:48:55 -0500 Received: from gateway22.websitewelcome.com ([192.185.47.228]:31574 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727872AbeK2Asz (ORCPT ); Wed, 28 Nov 2018 19:48:55 -0500 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 4237319017 for ; Wed, 28 Nov 2018 07:47:12 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id S0BMgK96QSjJAS0BMghX6H; Wed, 28 Nov 2018 07:47:12 -0600 X-Authority-Reason: nr=8 Received: from [189.250.78.127] (port=44566 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gS0BL-004HQw-8Z; Wed, 28 Nov 2018 07:47:11 -0600 Subject: Re: [PATCH 02/41] scsi: NCR5380: Mark expected switch fall-through To: Michael Schmitz , Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <8b4ef418aa7803199954100fd89717f38d61ae06.1543374820.git.gustavo@embeddedor.com> <0caad885-94ad-9226-fbf1-996b5d465473@gmail.com> From: "Gustavo A. R. Silva" Message-ID: <304bd094-7079-3a90-4901-9c86833d49e2@embeddedor.com> Date: Wed, 28 Nov 2018 07:47:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <0caad885-94ad-9226-fbf1-996b5d465473@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.78.127 X-Source-L: No X-Exim-ID: 1gS0BL-004HQw-8Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.250.78.127]:44566 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On 11/28/18 2:22 AM, Michael Schmitz wrote: > I believe the 'if we get something weird' comment block relates to the > default branch of the switch, _not_ the fall through from the case above > (extended message received that we end up rejecting). Ordering the > comments like you did just for GCC's sake is misleading. > > The comment block should perhaps be moved after the default label. And > it would be nice if the reason for the fall through could be retained in > the comment. > Oh Okay. I'll do that. Thanks for the feedback. -- Gustavo