From: Quentin Schulz <quentin.schulz@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
knaack.h@gmx.de, "Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Lee Jones" <lee.jones@linaro.org>,
linux-iio@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Icenowy Zheng" <icenowy@aosc.xyz>,
"Bruno Prémont" <bonbons@linux-vserver.org>
Subject: Re: [PATCH 15/22] mfd: axp20x: add CHRG_CTRL1 to writeable regs for AXP20X/AXP22X
Date: Thu, 5 Jan 2017 09:10:35 +0100 [thread overview]
Message-ID: <304cdd9e-93a7-f554-99ce-e3e01762761d@free-electrons.com> (raw)
In-Reply-To: <CAGb2v67KmaECfFO+QBxKbtKscD0O=KNVHO1TS4FspYEdaLWUCA@mail.gmail.com>
On 05/01/2017 07:10, Chen-Yu Tsai wrote:
> On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz
> <quentin.schulz@free-electrons.com> wrote:
>> The CHR_CTRL1 register is made of 7 read-write bits with one being used
>> to set the target voltage for battery charging.
>
> The description is incorrect.
>
> All 8 bits are read-write:
>
> - The highest bit enables the charger module
> - Bits [6:5] set the target voltage
> - Bits [4:3] set when the charge cycle ends, based on percentage
> of charge current
> - Bits [2:0] set the charge current
>
> Feel free to use the above in the commit message.
>
Thanks for the correction.
>>
>> This adds the CHRG_CTRL1 register to the list of writeable registers for
>> AXP20X and AXP22X PMICs.
>
> You might want to add up to CHRG_CTRL3 for the AXP22x and CHRG_CTRL2
> for the AXP20x. These control additional aspects of the charger.
>
ACK.
> AXP20X_CHRG_BAK_CTRL controls the charger for the RTC battery. You
> could add this now, or let the person doing the RTC battery driver
> add it.
I'll let the person adding the RTC battery driver add it.
Thanks,
Quentin
--
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-01-05 8:19 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 16:37 [PATCH 00/22] add support for AXP20X and AXP22X power supply drivers Quentin Schulz
2017-01-02 16:37 ` [PATCH 01/22] dt-bindings: iio: adc: add AXP20X/AXP22X ADC DT binding Quentin Schulz
2017-01-03 23:20 ` Rob Herring
2017-01-05 4:05 ` Chen-Yu Tsai
2017-01-05 16:40 ` Maxime Ripard
2017-01-02 16:37 ` [PATCH 02/22] mfd: axp20x: add ADC data regs to volatile regs for AXP22X Quentin Schulz
2017-01-04 11:55 ` Lee Jones
2017-01-05 4:12 ` Chen-Yu Tsai
2017-01-02 16:37 ` [PATCH 03/22] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs Quentin Schulz
2017-01-05 5:42 ` Chen-Yu Tsai
2017-01-05 8:06 ` Quentin Schulz
2017-01-05 8:27 ` Chen-Yu Tsai
2017-01-05 9:50 ` Quentin Schulz
2017-01-05 10:28 ` Chen-Yu Tsai
2017-01-07 19:23 ` Jonathan Cameron
2017-01-05 16:46 ` Maxime Ripard
2017-01-07 19:20 ` Jonathan Cameron
2017-01-05 16:51 ` Maxime Ripard
2017-01-07 19:13 ` Jonathan Cameron
2017-01-02 16:37 ` [PATCH 04/22] mfd: axp20x: add ADC cells for AXP20X and AXP22X PMICs Quentin Schulz
2017-01-04 11:56 ` Lee Jones
2017-01-04 11:56 ` Lee Jones
2017-01-05 5:51 ` Chen-Yu Tsai
2017-01-02 16:37 ` [PATCH 05/22] ARM: dtsi: axp209: add AXP209 ADC subnode Quentin Schulz
2017-01-05 5:51 ` Chen-Yu Tsai
2017-01-05 8:08 ` Quentin Schulz
2017-01-05 8:16 ` Chen-Yu Tsai
2017-01-02 16:37 ` [PATCH 06/22] ARM: dtsi: axp22x: add AXP22X " Quentin Schulz
2017-01-05 5:52 ` Chen-Yu Tsai
2017-01-02 16:37 ` [PATCH 07/22] dt-bindings: power: supply: add AXP20X/AXP22X AC power supply Quentin Schulz
2017-01-04 13:14 ` Rob Herring
2017-01-05 6:17 ` Chen-Yu Tsai
2017-01-07 19:26 ` Jonathan Cameron
2017-01-02 16:37 ` [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs Quentin Schulz
2017-01-07 19:31 ` Jonathan Cameron
2017-01-08 10:41 ` Quentin Schulz
2017-01-17 3:00 ` Sebastian Reichel
2017-01-26 13:32 ` Quentin Schulz
2017-01-27 8:20 ` Maxime Ripard
2017-01-28 14:30 ` Jonathan Cameron
2017-01-29 15:16 ` Sebastian Reichel
2017-01-02 16:37 ` [PATCH 09/22] mfd: axp20x: add AC power supply cells for " Quentin Schulz
2017-01-04 11:57 ` Lee Jones
2017-01-02 16:37 ` [PATCH 10/22] ARM: dtsi: axp209: add AC power supply subnode Quentin Schulz
2017-01-02 16:37 ` [PATCH 11/22] ARM: dtsi: axp22x: " Quentin Schulz
2017-01-02 16:37 ` [PATCH 12/22] ARM: dts: sun8i: sina33: enable ACIN " Quentin Schulz
2017-01-02 16:37 ` [PATCH 13/22] ARM: sun5i: chip: " Quentin Schulz
2017-01-02 16:37 ` [PATCH 14/22] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding Quentin Schulz
2017-01-04 13:21 ` Rob Herring
2017-01-07 19:33 ` Jonathan Cameron
2017-01-08 10:48 ` Quentin Schulz
2017-01-08 10:59 ` Jonathan Cameron
2017-01-02 16:37 ` [PATCH 15/22] mfd: axp20x: add CHRG_CTRL1 to writeable regs for AXP20X/AXP22X Quentin Schulz
2017-01-04 11:57 ` Lee Jones
2017-01-05 6:10 ` Chen-Yu Tsai
2017-01-05 8:10 ` Quentin Schulz [this message]
2017-01-02 16:37 ` [PATCH 16/22] mfd: axp20x: add V_OFF to writeable regs for AXP20X and AXP22X Quentin Schulz
2017-01-04 11:57 ` Lee Jones
2017-01-05 6:02 ` Chen-Yu Tsai
2017-01-02 16:37 ` [PATCH 17/22] power: supply: add battery driver for AXP20X and AXP22X PMICs Quentin Schulz
2017-01-05 17:02 ` Maxime Ripard
2017-01-05 17:34 ` Ezequiel Garcia
2017-01-06 2:46 ` Sebastian Reichel
2017-01-06 3:39 ` Chen-Yu Tsai
2017-01-06 8:29 ` Quentin Schulz
2017-01-17 3:46 ` Sebastian Reichel
2017-01-02 16:37 ` [PATCH 18/22] mfd: axp20x: add MFD cells for AXP20X and AXP22X battery driver Quentin Schulz
2017-01-04 11:57 ` Lee Jones
2017-01-02 16:37 ` [PATCH 19/22] ARM: dtsi: axp209: add battery power supply subnode Quentin Schulz
2017-01-02 16:37 ` [PATCH 20/22] ARM: dtsi: axp22x: " Quentin Schulz
2017-01-02 16:37 ` [PATCH 21/22] ARM: dts: sun8i: sina33: enable " Quentin Schulz
2017-01-02 16:37 ` [PATCH 22/22] ARM: sun5i: chip: " Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304cdd9e-93a7-f554-99ce-e3e01762761d@free-electrons.com \
--to=quentin.schulz@free-electrons.com \
--cc=bonbons@linux-vserver.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.xyz \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).