linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] smack: mark 'smack_enabled' global variable as __initdata
@ 2021-06-29 13:41 Austin Kim
  2021-07-07 10:14 ` Austin Kim
  2021-07-20 17:36 ` Casey Schaufler
  0 siblings, 2 replies; 4+ messages in thread
From: Austin Kim @ 2021-06-29 13:41 UTC (permalink / raw)
  To: casey, jmorris, serge
  Cc: linux-security-module, linux-kernel, kernel-team, austindh.kim

From: Austin Kim <austin.kim@lge.com>

Mark 'smack_enabled' as __initdata
since it is only used during initialization code.

Signed-off-by: Austin Kim <austin.kim@lge.com>
---
 security/smack/smack.h     | 2 +-
 security/smack/smack_lsm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/smack/smack.h b/security/smack/smack.h
index c3cfbdf4944a..99c3422596ab 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -302,7 +302,7 @@ int smack_populate_secattr(struct smack_known *skp);
 /*
  * Shared data.
  */
-extern int smack_enabled;
+extern int smack_enabled __initdata;
 extern int smack_cipso_direct;
 extern int smack_cipso_mapped;
 extern struct smack_known *smack_net_ambient;
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 223a6da0e6dc..cacbe7518519 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -54,7 +54,7 @@
 static DEFINE_MUTEX(smack_ipv6_lock);
 static LIST_HEAD(smk_ipv6_port_list);
 struct kmem_cache *smack_rule_cache;
-int smack_enabled;
+int smack_enabled __initdata;
 
 #define A(s) {"smack"#s, sizeof("smack"#s) - 1, Opt_##s}
 static struct {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] smack: mark 'smack_enabled' global variable as __initdata
  2021-06-29 13:41 [PATCH] smack: mark 'smack_enabled' global variable as __initdata Austin Kim
@ 2021-07-07 10:14 ` Austin Kim
  2021-07-07 14:27   ` Casey Schaufler
  2021-07-20 17:36 ` Casey Schaufler
  1 sibling, 1 reply; 4+ messages in thread
From: Austin Kim @ 2021-07-07 10:14 UTC (permalink / raw)
  To: casey, James Morris, Serge E. Hallyn
  Cc: linux-security-module, Linux Kernel Mailing List, kernel-team

2021년 6월 29일 (화) 오후 10:41, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> From: Austin Kim <austin.kim@lge.com>
>
> Mark 'smack_enabled' as __initdata
> since it is only used during initialization code.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>
> ---
>  security/smack/smack.h     | 2 +-
>  security/smack/smack_lsm.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index c3cfbdf4944a..99c3422596ab 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -302,7 +302,7 @@ int smack_populate_secattr(struct smack_known *skp);
>  /*
>   * Shared data.
>   */
> -extern int smack_enabled;
> +extern int smack_enabled __initdata;
>  extern int smack_cipso_direct;
>  extern int smack_cipso_mapped;
>  extern struct smack_known *smack_net_ambient;
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 223a6da0e6dc..cacbe7518519 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -54,7 +54,7 @@
>  static DEFINE_MUTEX(smack_ipv6_lock);
>  static LIST_HEAD(smk_ipv6_port_list);
>  struct kmem_cache *smack_rule_cache;
> -int smack_enabled;
> +int smack_enabled __initdata;
>
>  #define A(s) {"smack"#s, sizeof("smack"#s) - 1, Opt_##s}
>  static struct {
> --
> 2.20.1
>

Dear Maintainers

Would you please review the above patch if you are available?
It might not take long.

Thanks.
Austin Kim

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] smack: mark 'smack_enabled' global variable as __initdata
  2021-07-07 10:14 ` Austin Kim
@ 2021-07-07 14:27   ` Casey Schaufler
  0 siblings, 0 replies; 4+ messages in thread
From: Casey Schaufler @ 2021-07-07 14:27 UTC (permalink / raw)
  To: Austin Kim, James Morris, Serge E. Hallyn
  Cc: linux-security-module, Linux Kernel Mailing List, kernel-team,
	Casey Schaufler

On 7/7/2021 3:14 AM, Austin Kim wrote:
> 2021년 6월 29일 (화) 오후 10:41, Austin Kim <austindh.kim@gmail.com>님이 작성:
>> From: Austin Kim <austin.kim@lge.com>
>>
>> Mark 'smack_enabled' as __initdata
>> since it is only used during initialization code.
>>
>> Signed-off-by: Austin Kim <austin.kim@lge.com>

I will be taking this patch for 5.15. You should see it in next
shortly after the 5.14 merge window closes.

>> ---
>>  security/smack/smack.h     | 2 +-
>>  security/smack/smack_lsm.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/security/smack/smack.h b/security/smack/smack.h
>> index c3cfbdf4944a..99c3422596ab 100644
>> --- a/security/smack/smack.h
>> +++ b/security/smack/smack.h
>> @@ -302,7 +302,7 @@ int smack_populate_secattr(struct smack_known *skp);
>>  /*
>>   * Shared data.
>>   */
>> -extern int smack_enabled;
>> +extern int smack_enabled __initdata;
>>  extern int smack_cipso_direct;
>>  extern int smack_cipso_mapped;
>>  extern struct smack_known *smack_net_ambient;
>> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
>> index 223a6da0e6dc..cacbe7518519 100644
>> --- a/security/smack/smack_lsm.c
>> +++ b/security/smack/smack_lsm.c
>> @@ -54,7 +54,7 @@
>>  static DEFINE_MUTEX(smack_ipv6_lock);
>>  static LIST_HEAD(smk_ipv6_port_list);
>>  struct kmem_cache *smack_rule_cache;
>> -int smack_enabled;
>> +int smack_enabled __initdata;
>>
>>  #define A(s) {"smack"#s, sizeof("smack"#s) - 1, Opt_##s}
>>  static struct {
>> --
>> 2.20.1
>>
> Dear Maintainers
>
> Would you please review the above patch if you are available?
> It might not take long.
>
> Thanks.
> Austin Kim

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] smack: mark 'smack_enabled' global variable as __initdata
  2021-06-29 13:41 [PATCH] smack: mark 'smack_enabled' global variable as __initdata Austin Kim
  2021-07-07 10:14 ` Austin Kim
@ 2021-07-20 17:36 ` Casey Schaufler
  1 sibling, 0 replies; 4+ messages in thread
From: Casey Schaufler @ 2021-07-20 17:36 UTC (permalink / raw)
  To: Austin Kim, jmorris, serge
  Cc: linux-security-module, linux-kernel, kernel-team, Casey Schaufler

On 6/29/2021 6:41 AM, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
>
> Mark 'smack_enabled' as __initdata
> since it is only used during initialization code.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>

Added to Smack next.

> ---
>  security/smack/smack.h     | 2 +-
>  security/smack/smack_lsm.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index c3cfbdf4944a..99c3422596ab 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -302,7 +302,7 @@ int smack_populate_secattr(struct smack_known *skp);
>  /*
>   * Shared data.
>   */
> -extern int smack_enabled;
> +extern int smack_enabled __initdata;
>  extern int smack_cipso_direct;
>  extern int smack_cipso_mapped;
>  extern struct smack_known *smack_net_ambient;
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 223a6da0e6dc..cacbe7518519 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -54,7 +54,7 @@
>  static DEFINE_MUTEX(smack_ipv6_lock);
>  static LIST_HEAD(smk_ipv6_port_list);
>  struct kmem_cache *smack_rule_cache;
> -int smack_enabled;
> +int smack_enabled __initdata;
>  
>  #define A(s) {"smack"#s, sizeof("smack"#s) - 1, Opt_##s}
>  static struct {

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-20 17:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 13:41 [PATCH] smack: mark 'smack_enabled' global variable as __initdata Austin Kim
2021-07-07 10:14 ` Austin Kim
2021-07-07 14:27   ` Casey Schaufler
2021-07-20 17:36 ` Casey Schaufler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).