From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB3EC5ACC0 for ; Sun, 15 Mar 2020 10:47:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C699C206BE for ; Sun, 15 Mar 2020 10:47:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="INi1boVd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="CPUpVdyX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728309AbgCOKrn (ORCPT ); Sun, 15 Mar 2020 06:47:43 -0400 Received: from mail.z3ntu.xyz ([128.199.32.197]:60488 "EHLO mail.z3ntu.xyz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728234AbgCOKrm (ORCPT ); Sun, 15 Mar 2020 06:47:42 -0400 Received: by mail.z3ntu.xyz (Postfix, from userid 182) id 06106C436B; Sun, 15 Mar 2020 10:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1584269261; bh=K/jCEoevmLMa/jIMtbempZ4v4lAPs/LPy5wBlLKCZCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=INi1boVdw6+4Z9aVStGDJBmNbes0vSCzIP6TcLC2vgM7JT2y0q3Y1rpYjy5S8vnHB 23hC9dz+0Mt6WZqQ9DUJdfCdELf/QBwjUj67uPGGzdTLO5PbvChLNYKdT1ruljbKOg j3JRWhlF33Y9D759MCkAzEG/OFUyPwDZ8oHDLkCw= Received: from g550jk.localnet (80-110-124-168.cgn.dynamic.surfer.at [80.110.124.168]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 1C308C3FF8; Sun, 15 Mar 2020 10:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1584269257; bh=K/jCEoevmLMa/jIMtbempZ4v4lAPs/LPy5wBlLKCZCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CPUpVdyXytdfuyDOT5E19G5nuTqfUbnCoJigzZTZ3AYf4YlRwO5INewZ1ImB+wLo1 lTf3QUbbMWuQjX9Xpyc93GpQlid2p/hrg0On5G4Oh0QObDLFSSaNbMgDj89RuDbXON 6olTo/ofR49kgRyAMSD4Pu4vvWnHe0UVq47bGgnQ= From: Luca Weiss To: linux-leds@vger.kernel.org, Dan Murphy Cc: Heiko Stuebner , Icenowy Zheng , Jacek Anaszewski , Laurent Pinchart , Mark Rutland , Maxime Ripard , Pavel Machek , Rob Herring , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 2/3] dt-bindings: leds: Add binding for sgm3140 Date: Sun, 15 Mar 2020 11:47:36 +0100 Message-ID: <3051566.44csPzL39Z@g550jk> In-Reply-To: <4f848ab3-0e76-ae63-0771-758b1eaa0660@ti.com> References: <20200309203558.305725-1-luca@z3ntu.xyz> <20200309203558.305725-3-luca@z3ntu.xyz> <4f848ab3-0e76-ae63-0771-758b1eaa0660@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan On Mittwoch, 11. M=E4rz 2020 13:49:35 CET Dan Murphy wrote: > Luca >=20 > On 3/9/20 3:35 PM, Luca Weiss wrote: > > Add YAML devicetree binding for SGMICRO SGM3140 charge pump used for > > camera flash LEDs. > >=20 > > Signed-off-by: Luca Weiss > > --- > > Changes since RFC: > > - new patch > >=20 > > I'm not sure about the completeness of this binding as it doesn't > > mention the led subnode at all. > > The only existing led yaml binding is leds/leds-max77650.yaml which > > mentions the subnode but duplicates properties from documented in > > leds/common.txt. > >=20 > > .../bindings/leds/leds-sgm3140.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml new file mode > > 100644 > > index 000000000000..be9384573d02 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/leds-sgm3140.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SGMICRO SGM3140 500mA Buck/Boost Charge Pump LED Driver > > + > > +maintainers: > > + - Luca Weiss > > + > > +description: | > > + The SGM3140 is a current-regulated charge pump which can regulate two > > current + levels for Flash and Torch modes. > > + > > + It is controlled with two GPIO pins. >=20 > Please define "It". Not sure what is controlled here. >=20 "It" means the SGM3140. Not sure how else to write that or what the correct= =20 term for such a component is. >=20 > Dan Regards Luca