From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754637AbcHVUuv (ORCPT ); Mon, 22 Aug 2016 16:50:51 -0400 Received: from mout.web.de ([212.227.17.11]:61695 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753202AbcHVUut (ORCPT ); Mon, 22 Aug 2016 16:50:49 -0400 Subject: Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS To: Joe Perches References: <87shtwvm63.fsf@kamboji.qca.qualcomm.com> <7ceaa510dc9d2df05ec4b456baed7bb1415550b3.1471889575.git.joe@perches.com> Cc: Andrew Morton , Kalle Valo , Arend van Spriel , Andy Whitcroft , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Jouni Malinen , kernel-janitors@vger.kernel.org, Julia Lawall , linux-kernel@vger.kernel.org From: SF Markus Elfring Message-ID: <30522d64-8303-cf13-d967-a5759aeb2278@users.sourceforge.net> Date: Mon, 22 Aug 2016 22:50:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <7ceaa510dc9d2df05ec4b456baed7bb1415550b3.1471889575.git.joe@perches.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:+rbxabi/PeG+WbTCxomCQj34oqbQZF555tK7KUMrsOlgD59/xd8 O4F+Ju/T4dG8ONOnHL7P0YBeQl91j+tOb7Oa/ahV800ff7ABx2EKv5Llv3YOwRPwx++Mwu4 +Vun7VGIKR3gdjZ0Kf4TWvGLfHDYhA6tiJa/g2dJM7uejuOUXrIliT2oUSZh8by0JWY/7g7 SQ1PIau9D867u3sc4e2Vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:qi2ihLmtI0c=:4tEa0KCDBBj02XLX8rSs2i 3VI83mExEcrE0H0WZrYokDhv1YuC12RdkBtTTnV37rRrZ7uEBEdWFAaDZM+A+oZX4iiLejyH+ kbAPHuwBfJf7Ld2XnFU5p8dkmNjW4hBEZ8XdfWpf/7pMLJFflZrQ6IBqmmjuNFInh2nnfNpnL Y0oVyHtaa6Yhqg5/RyqG2kt4ZyJpvwEXOIIvPpusrwqLC6wko+3Xb0xxy3iJkghlNmKTw1iW+ gPeMJm0FdTqQhPt5miKmP2YWgfxaD/GsZypVxS6PVXTDmAEgjJMEfmkkCFBpuFerznEKuHC1l 6mAPmfG2OBj4lqoOUn9viGzJWYj8zQZWO5PFLeMsPXuUASqVBuMET9hQxDycsf9/0uNTV+jVf uJUXoAcO8Wj+eFpHgx2TpdaDQnv5PoiRgVwrRbQWnp1q7707sak5+ABq8YSfustPnX102qCbR lWTdHt4Hc1RVV2ly29BrpaE8UM7lw89flLQYGADg6xzoYrhANEcO68EDhDtGKhKHwRDoXhfev EDAaJJP1irHzc42smMZk9uc91JbWaY+DI3/PdJ4NejsmldAskFbzHlXdAC3zz+qmO5pg4A0kd OHxYeYHIv3qKx6JS8M6F9KIiHbeIiKsbC2dV1dLBeb62ZjBGBCuJ1K9iJPzzKXqLbiJoVk7EI Nv5wd40+qbQg+M4h3Q3NhN/+utbpjOc3JqxMMeM9gxDbY/bftFBuqqUqUKs4Np9OiyXwjcQU1 NqzWxyQmQfQ2O1ezb487pbs6hsiRJdXAq0EtD+kjfLwF+wUUhhcupgKslxXv05mO5n3qSbgW8 eddstnz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -2289,6 +2299,10 @@ sub process { > } > > if ($found_file) { > + if (is_maintained_obsolete($realfile)) { > + WARN("OBSOLETE", > + "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.\n"); > + } How do you think about to avoid a double negation in such a warning message? Would a wording like "… Only really necessary modifications please.\n" be more useful here? Regards, Markus