From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1DEBC3A5A0 for ; Mon, 19 Aug 2019 21:03:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F0452087E for ; Mon, 19 Aug 2019 21:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbfHSVDd (ORCPT ); Mon, 19 Aug 2019 17:03:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56582 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728193AbfHSVDd (ORCPT ); Mon, 19 Aug 2019 17:03:33 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 098F030A5A56; Mon, 19 Aug 2019 21:03:33 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F6831001925; Mon, 19 Aug 2019 21:03:30 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <12308.1565876416@warthog.procyon.org.uk> <13106.1565951791@warthog.procyon.org.uk> To: Joe Perches Cc: dhowells@redhat.com, Nathan Chancellor , Nick Desaulniers , Nathan Huckleberry , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: Move comments after /* fallthrough */ MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <30554.1566248610.1@warthog.procyon.org.uk> Date: Mon, 19 Aug 2019 22:03:30 +0100 Message-ID: <30555.1566248610@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 19 Aug 2019 21:03:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches wrote: > /* extract the FID array and its count in two steps */ > - /* fall through */ > + fallthrough; > case 1: Okay, that doesn't look too bad. I thought you might be going to combine it with the case inside a macro in some way. David