linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Srinivas Neeli <srinivas.neeli@xilinx.com>,
	wg@grandegger.com, davem@davemloft.net, michal.simek@xilinx.com,
	appanad@xilinx.com
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, git@xilinx.com,
	nagasure@xilinx.com
Subject: Re: [PATCH 2/2] can: xilinx_can: Fix usage of skb memory
Date: Wed, 20 Nov 2019 13:37:32 +0100	[thread overview]
Message-ID: <30572daa-1c75-37a2-20f5-c1f818acc603@pengutronix.de> (raw)
In-Reply-To: <1574251865-19592-3-git-send-email-srinivas.neeli@xilinx.com>


[-- Attachment #1.1: Type: text/plain, Size: 635 bytes --]

On 11/20/19 1:11 PM, Srinivas Neeli wrote:
> As per linux can framework, driver not allowed to touch the skb memory
> after can_put_echo_skb() call.
> This patch fixes the same.
> https://www.spinics.net/lists/linux-can/msg02199.html

NACK.

Don't make a copy of the CAN frame, move the can_put_echo_skb() after
you don't need the skb anymore.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-11-20 12:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 12:11 [PATCH 0/2] can: xilinx_can: Bug fixes on can driver Srinivas Neeli
2019-11-20 12:11 ` [PATCH 1/2] can: xilinx_can: skip error message on deferred probe Srinivas Neeli
2019-11-22 14:28   ` Marc Kleine-Budde
2019-11-25  3:58   ` Appana Durga Kedareswara Rao
2019-11-20 12:11 ` [PATCH 2/2] can: xilinx_can: Fix usage of skb memory Srinivas Neeli
2019-11-20 12:37   ` Marc Kleine-Budde [this message]
2019-11-20 12:42 ` [PATCH 0/2] can: xilinx_can: Bug fixes on can driver Marc Kleine-Budde
2019-11-20 15:54   ` Appana Durga Kedareswara Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30572daa-1c75-37a2-20f5-c1f818acc603@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=appanad@xilinx.com \
    --cc=davem@davemloft.net \
    --cc=git@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=nagasure@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=srinivas.neeli@xilinx.com \
    --cc=wg@grandegger.com \
    --subject='Re: [PATCH 2/2] can: xilinx_can: Fix usage of skb memory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).