From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7AE2C742A1 for ; Fri, 12 Jul 2019 01:40:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B06902084B for ; Fri, 12 Jul 2019 01:40:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728981AbfGLBkr (ORCPT ); Thu, 11 Jul 2019 21:40:47 -0400 Received: from mga03.intel.com ([134.134.136.65]:10212 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbfGLBkr (ORCPT ); Thu, 11 Jul 2019 21:40:47 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 18:40:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,480,1557212400"; d="scan'208";a="249982626" Received: from xingzhen-mobl1.ccr.corp.intel.com (HELO [10.239.196.119]) ([10.239.196.119]) by orsmga001.jf.intel.com with ESMTP; 11 Jul 2019 18:40:44 -0700 Subject: Re: [PATCH v2] tracing: Add verbose gfp_flag printing to synthetic events To: Tom Zanussi , rostedt@goodmis.org, mingo@redhat.com, tom.zanussi@linux.intel.com Cc: linux-kernel@vger.kernel.org References: <20190711084642.28785-1-zhengjun.xing@linux.intel.com> <1562859753.29283.10.camel@kernel.org> From: Xing Zhengjun Message-ID: <3062dff1-1d77-251e-253b-19c6d95d5bdc@linux.intel.com> Date: Fri, 12 Jul 2019 09:40:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <1562859753.29283.10.camel@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tom, On 7/11/2019 11:42 PM, Tom Zanussi wrote: > Hi Zhengjun, > > The patch itself looks fine to me, but could you please create a v3 > with a couple changes to the commit message? I noticed you dropped > your original commit message - please add it back and combine with part > of mine, as below. Also, please keep your original Subject line > ('[PATCH] trace:add "gfp_t" support in synthetic_events') (but the > first word after trace:, 'add', should be capitalized.) > Thanks. I will send v3 version patch soon. > On Thu, 2019-07-11 at 16:46 +0800, Zhengjun Xing wrote: >> Add on top of 'trace:add "gfp_t" support in synthetic_events'. > > Please remove this part but keep the part below. > >> >> Prints the gfp flags as hex in addition to the human-readable flag >> string. Example output: >> >> whoopsie-630 [000] ...1 78.969452: testevent: bar=b20 >> (GFP_ATOMIC|__GFP_ZERO) >> rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC) >> rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC) >> > > So basically, something like this: > > [PATCH] trace: Add "gfp_t" support in synthetic_events > > Add "gfp_t" support in synthetic_events, then the "gfp_t" type > parameter in some functions can be traced. > > Print the gfp flags as hex in addition to the human-readable flag > string. Example output: > > whoopsie-630 [000] ...1 78.969452: testevent: bar=b20 (GFP_ATOMIC|__GFP_ZERO) > rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC) > rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC) > >> Signed-off-by: Tom Zanussi >> Signed-off-by: Zhengjun Xing > > > Thanks, > > Tom > >> --- >> kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/kernel/trace/trace_events_hist.c >> b/kernel/trace/trace_events_hist.c >> index ca6b0dff60c5..938ef3f54c5c 100644 >> --- a/kernel/trace/trace_events_hist.c >> +++ b/kernel/trace/trace_events_hist.c >> @@ -13,6 +13,10 @@ >> #include >> #include >> >> +/* for gfp flag names */ >> +#include >> +#include >> + >> #include "tracing_map.h" >> #include "trace.h" >> #include "trace_dynevent.h" >> @@ -752,6 +756,8 @@ static int synth_field_size(char *type) >> size = sizeof(unsigned long); >> else if (strcmp(type, "pid_t") == 0) >> size = sizeof(pid_t); >> + else if (strcmp(type, "gfp_t") == 0) >> + size = sizeof(gfp_t); >> else if (synth_field_is_string(type)) >> size = synth_field_string_size(type); >> >> @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type) >> fmt = "%lu"; >> else if (strcmp(type, "pid_t") == 0) >> fmt = "%d"; >> + else if (strcmp(type, "gfp_t") == 0) >> + fmt = "%x"; >> else if (synth_field_is_string(type)) >> fmt = "%s"; >> >> @@ -834,9 +838,20 @@ static enum print_line_t >> print_synth_event(struct trace_iterator *iter, >> i == se->n_fields - 1 ? "" >> : " "); >> n_u64 += STR_VAR_LEN_MAX / sizeof(u64); >> } else { >> + struct trace_print_flags __flags[] = { >> + __def_gfpflag_names, {-1, NULL} }; >> + >> trace_seq_printf(s, print_fmt, se- >>> fields[i]->name, >> entry->fields[n_u64], >> i == se->n_fields - 1 ? "" >> : " "); >> + >> + if (strcmp(se->fields[i]->type, "gfp_t") == >> 0) { >> + trace_seq_puts(s, " ("); >> + trace_print_flags_seq(s, "|", >> + entry- >>> fields[n_u64], >> + __flags); >> + trace_seq_putc(s, ')'); >> + } >> n_u64++; >> } >> } -- Zhengjun Xing