From: "Sunnanyong (Nanyong Sun, Intelligent Computing Solution Development Dep)" <sunnanyong@huawei.com>
To: <shuah@kernel.org>, <sfr@canb.auug.org.au>, <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <kirill.shutemov@linux.intel.com>,
<yang.shi@linux.alibaba.com>, <wangkefeng.wang@huawei.com>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH -next] khugepaged: selftests: remove debug_cow
Date: Fri, 28 May 2021 10:06:41 +0800 [thread overview]
Message-ID: <30666493-ad8a-67a3-9ee4-310466bcff7e@huawei.com> (raw)
In-Reply-To: <20210430051117.400189-1-sunnanyong@huawei.com>
On 2021/4/30 13:11, Nanyong Sun wrote:
> The debug_cow attribute had been removed since commit 4958e4d86ecb01
> ("mm: thp: remove debug_cow switch"), so remove it in selftest code too,
> otherwise the khugepaged test will fail.
>
> Signed-off-by: Nanyong Sun <sunnanyong@huawei.com>
> ---
> tools/testing/selftests/vm/khugepaged.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/vm/khugepaged.c b/tools/testing/selftests/vm/khugepaged.c
> index 8b7582130..155120b67 100644
> --- a/tools/testing/selftests/vm/khugepaged.c
> +++ b/tools/testing/selftests/vm/khugepaged.c
> @@ -86,7 +86,6 @@ struct settings {
> enum thp_enabled thp_enabled;
> enum thp_defrag thp_defrag;
> enum shmem_enabled shmem_enabled;
> - bool debug_cow;
> bool use_zero_page;
> struct khugepaged_settings khugepaged;
> };
> @@ -95,7 +94,6 @@ static struct settings default_settings = {
> .thp_enabled = THP_MADVISE,
> .thp_defrag = THP_DEFRAG_ALWAYS,
> .shmem_enabled = SHMEM_NEVER,
> - .debug_cow = 0,
> .use_zero_page = 0,
> .khugepaged = {
> .defrag = 1,
> @@ -268,7 +266,6 @@ static void write_settings(struct settings *settings)
> write_string("defrag", thp_defrag_strings[settings->thp_defrag]);
> write_string("shmem_enabled",
> shmem_enabled_strings[settings->shmem_enabled]);
> - write_num("debug_cow", settings->debug_cow);
> write_num("use_zero_page", settings->use_zero_page);
>
> write_num("khugepaged/defrag", khugepaged->defrag);
> @@ -304,7 +301,6 @@ static void save_settings(void)
> .thp_defrag = read_string("defrag", thp_defrag_strings),
> .shmem_enabled =
> read_string("shmem_enabled", shmem_enabled_strings),
> - .debug_cow = read_num("debug_cow"),
> .use_zero_page = read_num("use_zero_page"),
> };
> saved_settings.khugepaged = (struct khugepaged_settings) {
This patch has not been responded for a long time.
Could someone please help to deal with it ?
next prev parent reply other threads:[~2021-05-28 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 5:11 [PATCH -next] khugepaged: selftests: remove debug_cow Nanyong Sun
2021-05-28 2:06 ` Sunnanyong (Nanyong Sun, Intelligent Computing Solution Development Dep) [this message]
2021-05-28 11:01 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30666493-ad8a-67a3-9ee4-310466bcff7e@huawei.com \
--to=sunnanyong@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).