From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DATE_IN_PAST_96_XX, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A5AC433E2 for ; Tue, 1 Sep 2020 21:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF75F2078B for ; Tue, 1 Sep 2020 21:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729453AbgIAVi6 convert rfc822-to-8bit (ORCPT ); Tue, 1 Sep 2020 17:38:58 -0400 Received: from mailoutvs47.siol.net ([185.57.226.238]:38772 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728179AbgIAViy (ORCPT ); Tue, 1 Sep 2020 17:38:54 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 282055267C4; Tue, 1 Sep 2020 23:38:52 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JNyKGgweMjQS; Tue, 1 Sep 2020 23:38:51 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id B612452644C; Tue, 1 Sep 2020 23:38:51 +0200 (CEST) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id ECFCB5263BF; Tue, 1 Sep 2020 23:38:50 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ezequiel Garcia Cc: Tomasz Figa , kernel@collabora.com, Jonas Karlman , Hans Verkuil , Alexandre Courbot , Jeffrey Kardatzke , Nicolas Dufresne , Philipp Zabel , Maxime Ripard , Paul Kocialkowski , Ezequiel Garcia Subject: Re: [PATCH v2 00/14] Clean H264 stateless uAPI Date: Tue, 11 Aug 2020 21:16:09 +0200 Message-ID: <3072394.25LIjdDuC7@kista> In-Reply-To: <20200806151310.98624-1-ezequiel@collabora.com> References: <20200806151310.98624-1-ezequiel@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Dne četrtek, 06. avgust 2020 ob 17:12:56 CEST je Ezequiel Garcia napisal(a): > Here's a new round for the H.264 uAPI cleanup, which as discussed > aims at being stabilized and promoted as a first-class public uAPI soon. > > It should be noted that there is already GStreamer native > support for this interface, which will be part of 1.18, > once it's released. > > I have pushed a branch porting GStreamer to > support these interface changes: > > https://gitlab.freedesktop.org/ezequielgarcia/gst-plugins-bad/-/commits/for_ > h264_uapi_v3 > > As was discussed the SLICE_PARAMS control is now clarified > to work for one-slice-per-request operation, using CAPTURE > buffer holding features. This is how Cedrus driver is implemented. > > The other drivers currently supported Hantro and Rockchip VDEC, > as well as the MTK stateless decoder posted by Alex Courbot > operate in frame-based mode. > > These "frame-based" devices parse the slice headers in hardware, > and therefore shall not support SLICE_PARAMS. To that extent, > the redundant bitstream fields are now part of the DECODE_PARAMS > control. > > Hopefully now the specification documentation is clear enough. > GStreamer, Chromium and FFmpeg (which I'm sure will be implemented > as soon as we stabilize the API) should serve as reference examples > on how the API is consumed. > I tested this series using https://github.com/Kwiboo/FFmpeg/commits/v4l2-request-hwaccel-4.3.1 on Cedrus (Allwinner H6) using additional patch contained in discussion around patch 3 and I couldn't find any issue. You can add to whole series: Tested-by: Jernej Skrabec Best regards, Jernej