From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966589AbcIHPDF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 11:03:05 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:58931 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966552AbcIHPDD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 11:03:03 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] dax: use correct dev_t value
Date: Thu, 08 Sep 2016 17:03:35 +0200
Message-ID: <3073570.usRicVAIWU@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAPcyv4gfW4MdZJmueAY34D4+NzzHDrJyj1Hzg8v8fzyYphpFLw@mail.gmail.com>
References: <20160908135431.1310985-1-arnd@arndb.de> <CAPcyv4gfW4MdZJmueAY34D4+NzzHDrJyj1Hzg8v8fzyYphpFLw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:YA2oAw1ZuMzuAh/V47vVV2p6yxEsNG+MVXISoK6uq1HXsxorx0H
 c8WyN1XKkdzanq2Ls1zu/k0mN+XLV3e+9c3Vp9WVP9knntdv0hqIufbf2/w75XjUFpapRja
 04bU6uhzeAsyNTA4D1EUGl9zXMqvDUS/vp8oCJ20cErtl1hF65NOV0dqouyubWDDe80Jy6F
 qCzP6PTLlX+eVVDN1djdQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:u30LDYlVACg=:fuhwXB5UFFFjBS4OtIkzCk
 hYeiYbz/Qq99LRFMyNZjs5WpndbzkhU7PwIVQYTlGp9oBF+QMJmAIx+ojDaq4ezx1JhmrI87N
 NZLkXPRPyjX7s6o4/TGdKKR7LEwgSI0cbTACOMzR6RHVWIAw0wxake8gsDG3YELIC7zKPyHs8
 YaJ6IWc0hAkSAz1XymC/oL2GbXSOZ01fVyfdhRI9/rNDS4Tjb/ttUGPVn0oWOkyORSJBdVJXy
 TF2HadiWWLt6Aho9TVPIfFj7YeqlhuGIvAL2xBAB6WsAd0XpEWUu1GGz+Ocd2ce0Cyrx1IAns
 ItjxP3XisgsCChD2sBubvcYO690eAgVgLiCel6Y9vzv4pUsgue9FlOEbA0Ew55/1JCDnvrlqT
 kBdSYSFibfgyUB/38WVxAlfgl01fiTa2/rFhUbP0/QccUhMetQvr8fmDngBnQ4WYE25nOlVAH
 WJFNpPAo515l/e/ZpM4JkFpNQMmLmpxKqRjCiKSzRGuoy+cd4Kc5Ktz07abq7pvTYy1OQ72D3
 Vpv5uDUkzea22qs8/R3L8rbBNgA7W3HxLJo4ogozTLB2KUrMOJzJ78R68kcGOFkRVP7FEDLAF
 MOcdT5lEdVMfjoQ7RhW5yvE/EQeO03+/m/vbwHGPgu/+aRReQtx2PP0XintFHU/nlyegLaibD
 ozBC9zHESoeBXokPilqwY+K+AYHaL1mdWqnkW0Z9ahyIcQfNH3SIC0x+paWn6spzYZ4v3r0b+
 zStMx+3u3KdPZCGw
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, September 8, 2016 7:56:31 AM CEST Dan Williams wrote:
> On Thu, Sep 8, 2016 at 6:53 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The dev_t variable in devm_create_dax_dev() is used before it's
> > first set:
> >
> > drivers/dax/dax.c: In function 'devm_create_dax_dev':
> > drivers/dax/dax.c:205:39: error: 'dev_t' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >   inode = iget5_locked(dax_superblock, hash_32(devt + DAXFS_MAGIC, 31),
> >                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/dax/dax.c:688:8: note: 'dev_t' was declared here
> >
> > This reorders the code to how it looks correct to me.
> >
> 
> Looks good to me.
> 
> Strange, I don't see this error with gcc-5.3.1, I assume 0day missed
> it for a similar reason?

No, the warning is disabled by now since 6e8d666e9253 ("Disable
"maybe-uninitialized" warning globally"), which I have reverted
locally.

You can also build with -Wmaybe-uninitialized, but that causes
many false positives if any of these options are enabled:

CONFIG_CC_OPTIMIZE_FOR_SIZE
CONFIG_PROFILE_ALL_BRANCHES
CONFIG_UBSAN_SANITIZE_ALL
CONFIG_GCOV_PROFILE_ALL

I'm still trying to come up with a way to get the warning to
be useful again without annoying Linus too much.

	Arnd