From: Michael Walle <michael@walle.cc>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
yangbo lu <yangbo.lu@freescale.com>
Subject: Re: [PATCH] mmc: sdhci-of-esdhc: fixup PRESENT_STATE read
Date: Fri, 11 Nov 2016 14:25:51 +0100 [thread overview]
Message-ID: <307509ddddf1fd672a7e749acd9582c1@walle.cc> (raw)
In-Reply-To: <0a5454e6-efa6-744e-4a2d-123a47e7cc40@intel.com>
Am 2016-11-11 14:15, schrieb Adrian Hunter:
> On 10/11/16 18:47, Michael Walle wrote:
>> Since commit 87a18a6a5652 ("mmc: mmc: Use ->card_busy() to detect busy
>> cards in __mmc_switch()") the ESDHC driver is broken:
>> mmc0: Card stuck in programming state! __mmc_switch
>> mmc0: error -110 whilst initialising MMC card
>>
>> Since this commit __mmc_switch() uses ->card_busy(), which is
>> sdhci_card_busy() for the esdhc driver. sdhci_card_busy() uses the
>> PRESENT_STATE register, specifically the DAT0 signal level bit. But
>> the
>> ESDHC uses a non-conformant PRESENT_STATE register, thus a read fixup
>> is
>> required to make the driver work again.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>
> Could add a Fixes tag here.
ah, right, will do :)
>
>> ---
>> drivers/mmc/host/sdhci-of-esdhc.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c
>> b/drivers/mmc/host/sdhci-of-esdhc.c
>> index fb71c86..243fee9 100644
>> --- a/drivers/mmc/host/sdhci-of-esdhc.c
>> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
>> @@ -66,6 +66,18 @@ static u32 esdhc_readl_fixup(struct sdhci_host
>> *host,
>> return ret;
>> }
>> }
>> + /*
>> + * The DAT[3:0] line signal levels and the CMD line signal level is
>> + * not compatible with standard SDHC reegister. Move the
>> corresponding
>
> reegister -> register
ok
>
>> + * bits around.
>> + */
>> + if (spec_reg == SDHCI_PRESENT_STATE) {
>> + ret = value & 0xf8000000;
>> + ret |= (value >> 4) & SDHCI_DATA_LVL_MASK;
>> + ret |= (value << 1) & 0x01000000;
>> + return ret;
>
> SDHCI also uses other bits in SDHCI_PRESENT_STATE like
> SDHCI_CMD_INHIBIT and
> SDHCI_DATA_INHIBIT etc, but this looks like all those bits will be
> zero. Is
> that right?
ugh, thanks for spotting that. actually all lower bits should be taken
from the original value. Therefore the first statement should be
ret = value & ~0xf8000000;
Will post a v2 soon.
-michael
prev parent reply other threads:[~2016-11-11 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 16:47 [PATCH] mmc: sdhci-of-esdhc: fixup PRESENT_STATE read Michael Walle
2016-11-11 13:15 ` Adrian Hunter
2016-11-11 13:25 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307509ddddf1fd672a7e749acd9582c1@walle.cc \
--to=michael@walle.cc \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yangbo.lu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).