linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
@ 2018-10-13 11:18 Enric Balletbo i Serra
  2018-10-15 23:11 ` Laurent Pinchart
  0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2018-10-13 11:18 UTC (permalink / raw)
  To: linux-kernel
  Cc: kernel, Andrzej Hajda, Daniel Vetter, Marek Szyprowski,
	Archit Taneja, zain wang, dri-devel, Lin Huang, Douglas Anderson,
	David Airlie, Laurent Pinchart, Sean Paul, Jeffy Chen

This patch avoids that building the bridge/analogix source code with
smatch triggers complaints about inconsistent indenting.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index d68986cea132..75e2649d7515 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge)
 	 * plat_data->attch return, that's why we record the connector
 	 * point after plat attached.
 	 */
-	 if (dp->plat_data->attach) {
-		 ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
-		 if (ret) {
-			 DRM_ERROR("Failed at platform attch func\n");
-			 return ret;
-		 }
+	if (dp->plat_data->attach) {
+		ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
+		if (ret) {
+			DRM_ERROR("Failed at platform attch func\n");
+			return ret;
+		}
 	}
 
 	if (dp->plat_data->panel) {
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
  2018-10-13 11:18 [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch Enric Balletbo i Serra
@ 2018-10-15 23:11 ` Laurent Pinchart
  2018-10-16  9:43   ` Enric Balletbo i Serra
  0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2018-10-15 23:11 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: linux-kernel, kernel, Andrzej Hajda, Daniel Vetter,
	Marek Szyprowski, Archit Taneja, zain wang, dri-devel, Lin Huang,
	Douglas Anderson, David Airlie, Sean Paul, Jeffy Chen

Hi Enric,

Thank you for the patch.

On Saturday, 13 October 2018 14:18:44 EEST Enric Balletbo i Serra wrote:
> This patch avoids that building the bridge/analogix source code with
> smatch triggers complaints about inconsistent indenting.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> 
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index
> d68986cea132..75e2649d7515 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct
> drm_bridge *bridge) * plat_data->attch return, that's why we record the
> connector
>  	 * point after plat attached.
>  	 */
> -	 if (dp->plat_data->attach) {
> -		 ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
> -		 if (ret) {
> -			 DRM_ERROR("Failed at platform attch func\n");
> -			 return ret;
> -		 }
> +	if (dp->plat_data->attach) {
> +		ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
> +		if (ret) {
> +			DRM_ERROR("Failed at platform attch func\n");
> +			return ret;
> +		}
>  	}

This looks good to me. While at it, could you s/attch/attach/ ? With that 
fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  	if (dp->plat_data->panel) {

-- 
Regards,

Laurent Pinchart




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
  2018-10-15 23:11 ` Laurent Pinchart
@ 2018-10-16  9:43   ` Enric Balletbo i Serra
  0 siblings, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2018-10-16  9:43 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: linux-kernel, kernel, Andrzej Hajda, Daniel Vetter,
	Marek Szyprowski, Archit Taneja, zain wang, dri-devel, Lin Huang,
	Douglas Anderson, David Airlie, Sean Paul, Jeffy Chen

Ho Laurent,

On 16/10/18 01:11, Laurent Pinchart wrote:
> Hi Enric,
> 
> Thank you for the patch.
> 
> On Saturday, 13 October 2018 14:18:44 EEST Enric Balletbo i Serra wrote:
>> This patch avoids that building the bridge/analogix source code with
>> smatch triggers complaints about inconsistent indenting.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index
>> d68986cea132..75e2649d7515 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> @@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct
>> drm_bridge *bridge) * plat_data->attch return, that's why we record the
>> connector
>>  	 * point after plat attached.
>>  	 */
>> -	 if (dp->plat_data->attach) {
>> -		 ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
>> -		 if (ret) {
>> -			 DRM_ERROR("Failed at platform attch func\n");
>> -			 return ret;
>> -		 }
>> +	if (dp->plat_data->attach) {
>> +		ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
>> +		if (ret) {
>> +			DRM_ERROR("Failed at platform attch func\n");
>> +			return ret;
>> +		}
>>  	}
> 
> This looks good to me. While at it, could you s/attch/attach/ ? With that 
> fixed,

Sure, will do now, just preparing v2.

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
>>  	if (dp->plat_data->panel) {
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-16  9:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-13 11:18 [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch Enric Balletbo i Serra
2018-10-15 23:11 ` Laurent Pinchart
2018-10-16  9:43   ` Enric Balletbo i Serra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).