From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753304AbcFJWXS (ORCPT ); Fri, 10 Jun 2016 18:23:18 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:62330 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbcFJWXQ (ORCPT ); Fri, 10 Jun 2016 18:23:16 -0400 From: Arnd Bergmann To: Deepa Dinamani , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Al Viro , Linus Torvalds , y2038@lists.linaro.org, Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org, Evgeniy Dushistov , OGAWA Hirofumi , Jan Kara , linux-ext4@vger.kernel.org, David Howells , linux-afs@lists.infradead.org, "Tigran A. Aivazian" , "Theodore Ts'o" , Andreas Dilger , Jan Kara , Jan Harkes , coda@cs.cmu.edu, linux-karma-devel@lists.sourceforge.net, Christoph Hellwig Subject: Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Date: Sat, 11 Jun 2016 00:21:54 +0200 Message-ID: <3091973.UMxUogx2eG@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1465448705-25055-2-git-send-email-deepa.kernel@gmail.com> References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-2-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MhawtmfQobg7a0Av+mAJhEX3VRh0WgunOejG1oBeZcv8RudJagG pCbTDmXaMfLP6XgzCEaoHPor/l74513EI1SEQzJS4btiLtA+sjLme+q8d1g3VjaF2/3X6sy EkkCTRJalHJSciikxo+UpKWS79ji89IazAA4ehcbyv3vih4Zq7UmBj7ry6scaezbct+inLy hM+58SMFhKch/rZdaOygA== X-UI-Out-Filterresults: notjunk:1;V01:K0:a5G9hNcIb2M=:+SdSG3ytlgCp9goNnId7tB 0FU0aCnc3z0pqPh4PI99EXtR2Ls8vLFzg+RrsrUtHSWU3l/VEBRBcwv7dqpCF9IiRQEKu8dBs wWpGeSrLSOcYgOw/khzvOoBdEbqhSkT7lSTiQyKctnUzfYPB7Vtbg1bEKtV1mYxg5hJJs8hhw dQVgz1QqLHFTiCzlzjMYk5O8qbMIz7XlVE3jsXzRbfEsTbKaFeTRd3ge4u537xExVr6qUrctC CNoSu5K0RmaCUKelYl6FRPpq7/qrm1zA9B4QVcUB8h82WMZQE57CxCNh5dsSkvB1X5o7d5BkA gtm2JwpFmPBN/WsRnLHQgxsPO03YLFTHeHU6uVJvu0WAfPIKtGQNG9sLG3AE6k8uqrHtNuw0u UlrKFEujBZDZB3XO4iQ6Qq4iKLzqYgUkO+qI3LSgbA94Wh0S1ZKw1HPHFzZ5XDa5fe4ursaIN B/QrU7y2Bb6+NK6iznzUSTElESvMqI+D+WFOPySl/ek8HMYPFiwr9ad9fsd1j5uNELkt9AvDs GZ/QDKYN0WcByHhy5s36T/NCaClQrwpK2Xrbaoew2OMZaZQNaXD21a1ieMfJl0ILdGt8V6blY z3SZH/FLJwbfbu0KUHK2E01z788QtJCJRrxCh35n7ctOjO2EjUlzyy8axQ0UAZysqit+MeJGT bAPZ7nvPJIJvA3wvBeHXD2gVzm4gQxJSytCAvAOZtMoc8abo6WKJZcLPQ1jdh8bIIHIMafwuM WWwp4n33GyN1x5y9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 8, 2016 10:04:45 PM CEST Deepa Dinamani wrote: > CURRENT_TIME_SEC is not y2038 safe. current_fs_time() will > be transitioned to use 64 bit time along with vfs in a > separate patch. > There is no plan to transistion CURRENT_TIME_SEC to use > y2038 safe time interfaces. > > current_fs_time() will also be extended to use superblock > range checking parameters when range checking is introduced. > > This works because alloc_super() fills in the the s_time_gran > in super block to NSEC_PER_SEC. > > Also note that filesystem specific times like the birthtime, > creation time that were using same interfaces to obtain time > retain same logistics. > > Signed-off-by: Deepa Dinamani one question: In an earlier version, you had a small optimization to use ktime_get_real_seconds() instead of current_kernel_time() when the granularity is seconds. Do you still plan to send that one, or did you decide we don't need it? Arnd