linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
To: Petr Mladek <pmladek@suse.com>, Jessica Yu <jeyu@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Patch to include/linux/kernel.h breaks 3rd party modules.
Date: Wed, 21 Dec 2016 15:42:05 -0500	[thread overview]
Message-ID: <30992.1482352925@turing-police.cc.vt.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

Yes, I know that usually out-of-tree modules are on their own.
However, this one may require a rethink..

(Sorry for not catching this sooner, I hadn't tried to deal with the
affected module since this patch hit linux-next in next-20161128)

commit 7fd8329ba502ef76dd91db561c7aed696b2c7720
Author: Petr Mladek <pmladek@suse.com>
Date:   Wed Sep 21 13:47:22 2016 +0200

    taint/module: Clean up global and module taint flags handling

Contains this chunk:

--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -506,6 +506,15 @@ extern enum system_states {
 #define TAINT_UNSIGNED_MODULE          13
 #define TAINT_SOFTLOCKUP               14
 #define TAINT_LIVEPATCH                        15
+#define TAINT_FLAGS_COUNT              16
+
+struct taint_flag {
+       char true;      /* character printed when tainted */
+       char false;     /* character printed when not tainted */
+       bool module;    /* also show as a per-module taint flag */
+};

and hilarity ensues when an out-of-tree module has this:

# ifndef true
#  define true  (1)
# endif
# ifndef false
#  define false (0)
# endif

My proposed fix: change true/false to tainted/untainted.  If this
is agreeable, I'll code and submit the fix.



[-- Attachment #2: Type: application/pgp-signature, Size: 484 bytes --]

             reply	other threads:[~2016-12-21 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 20:42 Valdis Kletnieks [this message]
2016-12-21 21:23 ` Patch to include/linux/kernel.h breaks 3rd party modules Jessica Yu
2016-12-22  0:53 ` Al Viro
2016-12-22  6:29 ` Christoph Hellwig
2016-12-22 10:40 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30992.1482352925@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=jeyu@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).