From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH] e1000e: fix cyclic resets at link up with active tx
Date: Fri, 1 Feb 2019 23:28:57 +0000 [thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B96621259@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <154747257030.250168.12931902291381446144.stgit@buzz>
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Konstantin Khlebnikov
> Sent: Monday, January 14, 2019 5:30 AM
> To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Kirsher,
> Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: linux-kernel@vger.kernel.org; David S. Miller <davem@davemloft.net>
> Subject: [PATCH] e1000e: fix cyclic resets at link up with active tx
>
> I'm seeing series of e1000e resets (sometimes endless) at system boot
> if something generates tx traffic at this time. In my case this is
> netconsole who sends message "e1000e 0000:02:00.0: Some CPU C-states
> have been disabled in order to enable jumbo frames" from e1000e itself.
> As result e1000_watchdog_task sees used tx buffer while carrier is off
> and start this reset cycle again.
>
> [ 17.794359] e1000e: eth1 NIC Link is Up 1000 Mbps Full Duplex, Flow
> Control: None
> [ 17.794714] IPv6: ADDRCONF(NETDEV_CHANGE): eth1: link becomes ready
> [ 22.936455] e1000e 0000:02:00.0 eth1: changing MTU from 1500 to 9000
> [ 23.033336] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 26.102364] e1000e: eth1 NIC Link is Up 1000 Mbps Full Duplex, Flow
> Control: None
> [ 27.174495] 8021q: 802.1Q VLAN Support v1.8
> [ 27.174513] 8021q: adding VLAN 0 to HW filter on device eth1
> [ 30.671724] cgroup: cgroup: disabling cgroup2 socket matching due to
> net_prio or net_cls activation
> [ 30.898564] netpoll: netconsole: local port 6666
> [ 30.898566] netpoll: netconsole: local IPv6 address
> 2a02:6b8:0:80b:beae:c5ff:fe28:23f8
> [ 30.898567] netpoll: netconsole: interface 'eth1'
> [ 30.898568] netpoll: netconsole: remote port 6666
> [ 30.898568] netpoll: netconsole: remote IPv6 address
> 2a02:6b8:b000:605c:e61d:2dff:fe03:3790
> [ 30.898569] netpoll: netconsole: remote ethernet address b0:a8:6e:f4:ff:c0
> [ 30.917747] console [netcon0] enabled
> [ 30.917749] netconsole: network logging started
> [ 31.453353] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 34.185730] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 34.321840] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 34.465822] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 34.597423] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 34.745417] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 34.877356] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 35.005441] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 35.157376] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 35.289362] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 35.417441] e1000e 0000:02:00.0: Some CPU C-states have been disabled in
> order to enable jumbo frames
> [ 37.790342] e1000e: eth1 NIC Link is Up 1000 Mbps Full Duplex, Flow
> Control: None
>
> This patch flushes tx buffers only once when carrier is off
> rather than at each watchdog iteration.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
prev parent reply other threads:[~2019-02-01 23:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 13:29 [PATCH] e1000e: fix cyclic resets at link up with active tx Konstantin Khlebnikov
2019-01-17 7:57 ` [Intel-wired-lan] " Neftin, Sasha
2019-01-17 12:10 ` Konstantin Khlebnikov
2019-02-01 23:28 ` Brown, Aaron F [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309B89C4C689E141A5FF6A0C5FB2118B96621259@ORSMSX103.amr.corp.intel.com \
--to=aaron.f.brown@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).