From: Mike Christie <michael.christie@oracle.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>,
lduncan@suse.com, cleech@redhat.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
Date: Sun, 26 Jul 2020 00:31:44 -0500 [thread overview]
Message-ID: <30b2622a-a04b-6b17-c50a-e6920be359ae@oracle.com> (raw)
In-Reply-To: <20200615081226.183068-1-jingxiangfeng@huawei.com>
On 6/15/20 3:12 AM, Jing Xiangfeng wrote:
> If scsi_host_lookup() failes we will jump to put_host, which may
> cause panic. Jump to exit_set_fnode to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/scsi/scsi_transport_iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index f4cc08e..c5e99f9 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -3291,7 +3291,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
> pr_err("%s could not find host no %u\n",
> __func__, ev->u.set_flashnode.host_no);
> err = -ENODEV;
> - goto put_host;
> + goto exit_set_fnode;
> }
>
> idx = ev->u.set_flashnode.flashnode_idx;
>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
next prev parent reply other threads:[~2020-07-26 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 8:12 [PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Jing Xiangfeng
2020-07-26 5:31 ` Mike Christie [this message]
2020-07-29 4:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30b2622a-a04b-6b17-c50a-e6920be359ae@oracle.com \
--to=michael.christie@oracle.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=jingxiangfeng@huawei.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).