* [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256
@ 2018-11-14 12:55 Liu Xiang
2018-11-14 14:01 ` Boris Brezillon
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Liu Xiang @ 2018-11-14 12:55 UTC (permalink / raw)
To: linux-mtd
Cc: linux-kernel, boris.brezillon, marek.vasut, dwmw2,
computersforpeace, richard, liuxiang_1999, Liu Xiang
The is25lp256 supports 4-byte opcodes and quad output.
Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 3e54e31..3eba13a 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1357,7 +1357,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
{ "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
SECT_4K | SPI_NOR_DUAL_READ) },
{ "is25lp256", INFO(0x9d6019, 0, 64 * 1024, 512,
- SECT_4K | SPI_NOR_DUAL_READ) },
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
{ "is25wp032", INFO(0x9d7016, 0, 64 * 1024, 64,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "is25wp064", INFO(0x9d7017, 0, 64 * 1024, 128,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256
2018-11-14 12:55 [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256 Liu Xiang
@ 2018-11-14 14:01 ` Boris Brezillon
2018-12-07 9:28 ` Tudor.Ambarus
2018-12-08 12:30 ` Boris Brezillon
2 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-11-14 14:01 UTC (permalink / raw)
To: Liu Xiang
Cc: linux-mtd, marek.vasut, richard, linux-kernel, liuxiang_1999,
computersforpeace, dwmw2, Tudor Ambarus
On Wed, 14 Nov 2018 20:55:18 +0800
Liu Xiang <liu.xiang6@zte.com.cn> wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
>
> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
This one looks good. Tudor, can you have a look?
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 3e54e31..3eba13a 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1357,7 +1357,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
> SECT_4K | SPI_NOR_DUAL_READ) },
> { "is25lp256", INFO(0x9d6019, 0, 64 * 1024, 512,
> - SECT_4K | SPI_NOR_DUAL_READ) },
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> { "is25wp032", INFO(0x9d7016, 0, 64 * 1024, 64,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "is25wp064", INFO(0x9d7017, 0, 64 * 1024, 128,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256
2018-11-14 12:55 [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256 Liu Xiang
2018-11-14 14:01 ` Boris Brezillon
@ 2018-12-07 9:28 ` Tudor.Ambarus
2018-12-08 12:30 ` Boris Brezillon
2 siblings, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2018-12-07 9:28 UTC (permalink / raw)
To: liu.xiang6, linux-mtd
Cc: marek.vasut, richard, linux-kernel, boris.brezillon,
liuxiang_1999, computersforpeace, dwmw2
On 11/14/2018 02:55 PM, Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
>
> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 3e54e31..3eba13a 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1357,7 +1357,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
> SECT_4K | SPI_NOR_DUAL_READ) },
> { "is25lp256", INFO(0x9d6019, 0, 64 * 1024, 512,
> - SECT_4K | SPI_NOR_DUAL_READ) },
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> { "is25wp032", INFO(0x9d7016, 0, 64 * 1024, 64,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "is25wp064", INFO(0x9d7017, 0, 64 * 1024, 128,
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: mtd: spi-nor: Add 4B_OPCODES flag to is25lp256
2018-11-14 12:55 [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256 Liu Xiang
2018-11-14 14:01 ` Boris Brezillon
2018-12-07 9:28 ` Tudor.Ambarus
@ 2018-12-08 12:30 ` Boris Brezillon
2 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-12-08 12:30 UTC (permalink / raw)
To: Liu Xiang, linux-mtd
Cc: Boris Brezillon, marek.vasut, richard, linux-kernel,
liuxiang_1999, computersforpeace, dwmw2
On Wed, 2018-11-14 at 12:55:18 UTC, Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
>
> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-08 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 12:55 [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256 Liu Xiang
2018-11-14 14:01 ` Boris Brezillon
2018-12-07 9:28 ` Tudor.Ambarus
2018-12-08 12:30 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).