From: Joerg Vehlow <lkml@jv-coder.de>
To: Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, bigeasy@linutronix.de
Cc: Joerg Vehlow <joerg.vehlow@aox-tech.de>
Subject: Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock
Date: Wed, 27 Nov 2019 08:35:01 +0100 [thread overview]
Message-ID: <30b9da41-437a-3b00-8306-82c7c44d1a91@jv-coder.de> (raw)
In-Reply-To: <46d5e7ea-011b-a384-ac7a-9ba63bbe9ea5@redhat.com>
Hi Tom,
I didn't remove it, I just posted my patch again.
I think it is up to the maintainers to decide if
it is required or not. Most people using the rt
patches will probably have PREEMPT_RT_FULL enabled anyway.
It will never be integrated into mainline kernel, because
the bug is already fixed in 5.0.19.
Jörg
Am 26.11.2019 um 16:31 schrieb Tom Rix:
> Why remove the #ifdef CONFIG_PREEMPT.. ?
>
>
>> + spin_lock_irqsave(&trans->queue.lock, flags);
>> skb_queue_splice_init(&trans->queue, &queue);
>> + spin_unlock_irqrestore(&trans->queue.lock, flags);
>>
> Fine otherwise.
>
> Tom
>
>
prev parent reply other threads:[~2019-11-27 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 7:13 [PATCH RT v3] net/xfrm/input: Protect queue with lock Joerg Vehlow
2019-11-26 8:40 ` Sebastian Andrzej Siewior
2019-11-26 15:31 ` Tom Rix
2019-11-27 7:35 ` Joerg Vehlow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30b9da41-437a-3b00-8306-82c7c44d1a91@jv-coder.de \
--to=lkml@jv-coder.de \
--cc=bigeasy@linutronix.de \
--cc=joerg.vehlow@aox-tech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).