From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
agross@kernel.org, andersson@kernel.org
Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: sc8280xp-x13s: Add soundcard support
Date: Mon, 28 Nov 2022 13:44:52 +0100 [thread overview]
Message-ID: <30be93a3-c57f-d4c9-c154-6f12b9dc5dc5@linaro.org> (raw)
In-Reply-To: <20221123104342.26140-4-srinivas.kandagatla@linaro.org>
On 23/11/2022 11:43, Srinivas Kandagatla wrote:
> +
> +&swr1 {
> + status = "okay";
> +
> + wcd_rx: wcd9380-rx@0,4 {
> + compatible = "sdw20217010d00";
> + reg = <0 4>;
> + qcom,rx-port-mapping = <1 2 3 4 5>;
> + };
> +};
> +
> +&swr2 {
> + status = "okay";
> +
> + wcd_tx: wcd9380-tx@0,3 {
> + compatible = "sdw20217010d00";
> + reg = <0 3>;
> + qcom,tx-port-mapping = <1 1 2 3>;
I think I solved my head-phones one-channel problem.
This should be <1 2 3> and in DTSI:
qcom,din-ports = <3>;
The downstream waipio-audio-overlay.dtsi says:
56 qcom,swr-port-mapping = <1 SWRM_TX1_CH1 0x1>,
57 <1 SWRM_TX1_CH2 0x2>,
58 <1 SWRM_TX1_CH3 0x4>, <1 SWRM_TX1_CH4 0x8>,
59 <2 SWRM_TX2_CH1 0x1>, <2 SWRM_TX2_CH2 0x2>,
60 <2 SWRM_TX2_CH3 0x4>, <2 SWRM_TX2_CH4 0x8>,
61 <3 SWRM_TX3_CH1 0x1>, <3 SWRM_TX3_CH2 0x2>,
62 <3 SWRM_TX3_CH3 0x4>, <3 SWRM_TX3_CH4 0x8>;
I just don't know what how to trim the port config properties - we
have there four entries, but channels are only three?
Where do these come from? The downstream:
asoc/waipio-port-config.h / lahaina-port-config.h
Do do not have port config for this SWR.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-28 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 10:43 [PATCH v4 0/3] arm64: dts: qcom: sc8280xp: add audio support Srinivas Kandagatla
2022-11-23 10:43 ` [PATCH v4 1/3] arm64: dts: qcom: sc8280xp: add gpr node Srinivas Kandagatla
2022-11-23 13:15 ` Konrad Dybcio
2022-11-24 9:59 ` Krzysztof Kozlowski
2022-11-23 10:43 ` [PATCH v4 2/3] arm64: dts: qcom: sc8280xp: add SoundWire and LPASS Srinivas Kandagatla
2022-11-23 13:16 ` Konrad Dybcio
2022-11-23 10:43 ` [PATCH v4 3/3] arm64: dts: qcom: sc8280xp-x13s: Add soundcard support Srinivas Kandagatla
2022-11-28 12:44 ` Krzysztof Kozlowski [this message]
2022-11-28 12:58 ` Krzysztof Kozlowski
2022-11-28 15:38 ` Srinivas Kandagatla
2022-12-28 4:36 ` [PATCH v4 0/3] arm64: dts: qcom: sc8280xp: add audio support Bjorn Andersson
2022-12-28 12:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30be93a3-c57f-d4c9-c154-6f12b9dc5dc5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).