LKML Archive on lore.kernel.org
 help / color / Atom feed
From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>, James Clark <james.clark@arm.com>
Cc: <linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <namhyung@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v6 00/12] perf tools: fix perf stat with large socket IDs
Date: Fri, 4 Dec 2020 11:48:36 +0000
Message-ID: <30c4426d-b314-98ff-e6d5-6d5152f316e8@huawei.com> (raw)
In-Reply-To: <20201203153923.GA3613481@krava>

On 03/12/2020 15:39, Jiri Olsa wrote:

+

> On Thu, Nov 26, 2020 at 04:13:16PM +0200, James Clark wrote:
>> Changes since v5:
>>    * Fix test for cpu_map__get_die() by shifting id before testing.
>>    * Fix test for cpu_map__get_socket() by not using cpu_map__id_to_socket()
>>      which is only valid in CPU aggregation mode.
>>
>> James Clark (12):
>>    perf tools: Improve topology test
>>    perf tools: Use allocator for perf_cpu_map
>>    perf tools: Add new struct for cpu aggregation
>>    perf tools: Replace aggregation ID with a struct
>>    perf tools: add new map type for aggregation
>>    perf tools: drop in cpu_aggr_map struct
>>    perf tools: Start using cpu_aggr_id in map
>>    perf tools: Add separate node member
>>    perf tools: Add separate socket member
>>    perf tools: Add separate die member
>>    perf tools: Add separate core member
>>    perf tools: Add separate thread member
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>
> 

Tested-by: John Garry <john.garry@huawei.com>

I still think that vendors (like us) need to fix/improve their firmware 
tables so that we don't get silly big numbers for socket/package IDs, 
like S5418-D0, below:

$./perf stat -a --per-die

  Performance counter stats for 'system wide':

S36-D0   48   72,216.31 msec cpu-clock      #   47.933 CPUs utilized
S36-D0   48        174     context-switches #   0.002 K/sec
S36-D0   48         48     cpu-migrations   #   0.001 K/sec
S36-D0   48         0     page-faults    #   0.000 K/sec
S36-D0   48   7,991,698     cycles    #   0.000 GHz
S36-D0   48   4,750,040     instructions   #   0.59  insn per cycle
S36-D0    1   <not supported>     branches
S36-D0   48      32,928     branch-misses    #   0.00% of all branches
S5418-D0   48   72,189.54 msec cpu-clock     #   47.915 CPUs utilized
S5418-D0   48        176     context-switches  #   0.002 K/sec
S5418-D0   48         48     cpu-migrations   #   0.001 K/sec
S5418-D0   48         0     page-faults     #   0.000 K/sec
S5418-D0   48   5,677,218     cycles    #    0.000 GHz
S5418-D0   48   3,872,285     instructions   #  0.68  insn per cycle
S5418-D0    1   <not supported>     branches
S5418-D0   48      29,208     branch-misses   #  0.00% of all branches

       1.506615297 seconds time elapsed

but at least it works now. Thanks.

> 
>>
>>   tools/perf/builtin-stat.c      | 128 ++++++++++++------------
>>   tools/perf/tests/topology.c    |  64 ++++++++++--
>>   tools/perf/util/cpumap.c       | 171 ++++++++++++++++++++++-----------
>>   tools/perf/util/cpumap.h       |  55 ++++++-----
>>   tools/perf/util/stat-display.c | 102 ++++++++++++--------
>>   tools/perf/util/stat.c         |   2 +-
>>   tools/perf/util/stat.h         |   9 +-
>>   7 files changed, 337 insertions(+), 194 deletions(-)
>>
>> -- 
>> 2.28.0
>>
> 
> .
> 


  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 14:13 James Clark
2020-11-26 14:13 ` [PATCH v6 01/12] perf tools: Improve topology test James Clark
2020-11-26 14:13 ` [PATCH v6 02/12] perf tools: Use allocator for perf_cpu_map James Clark
2020-11-26 14:13 ` [PATCH v6 03/12] perf tools: Add new struct for cpu aggregation James Clark
2020-11-26 14:13 ` [PATCH v6 04/12] perf tools: Replace aggregation ID with a struct James Clark
2020-11-26 14:13 ` [PATCH v6 05/12] perf tools: add new map type for aggregation James Clark
2020-11-26 14:13 ` [PATCH v6 06/12] perf tools: drop in cpu_aggr_map struct James Clark
2020-11-26 14:13 ` [PATCH v6 07/12] perf tools: Start using cpu_aggr_id in map James Clark
2020-11-26 14:13 ` [PATCH v6 08/12] perf tools: Add separate node member James Clark
2020-11-26 14:13 ` [PATCH v6 09/12] perf tools: Add separate socket member James Clark
2020-11-26 14:13 ` [PATCH v6 10/12] perf tools: Add separate die member James Clark
2020-11-26 14:13 ` [PATCH v6 11/12] perf tools: Add separate core member James Clark
2020-11-26 14:13 ` [PATCH v6 12/12] perf tools: Add separate thread member James Clark
2020-11-30 14:33 ` [PATCH v6 00/12] perf tools: fix perf stat with large socket IDs Namhyung Kim
2020-12-03 15:39 ` Jiri Olsa
2020-12-04 11:48   ` John Garry [this message]
2020-12-23 22:17     ` Jiri Olsa
2020-12-24 12:30       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30c4426d-b314-98ff-e6d5-6d5152f316e8@huawei.com \
    --to=john.garry@huawei.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git