From: Florian Fainelli <f.fainelli@gmail.com>
To: Jie Deng <Jie.Deng1@synopsys.com>,
davem@davemloft.net, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, CARLOS.PALMINHA@synopsys.com,
lars.persson@axis.com, thomas.lendacky@amd.com
Subject: Re: [PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII
Date: Thu, 8 Dec 2016 14:15:39 -0800 [thread overview]
Message-ID: <30c8257d-9ad9-71bf-a969-77dbe37bd800@gmail.com> (raw)
In-Reply-To: <6d4a65c5488364cdaec72eb22e742aa7e94dfebb.1481075763.git.jiedeng@synopsys.com>
On 12/06/2016 07:57 PM, Jie Deng wrote:
> This patch adds phy-mode support for Synopsys XLGMAC
The functional changes look good, but I would like to see some
description of what the XL part stands for here.
While you are modifying this, do you also mind submitting a Device Tree
specification change:
https://www.devicetree.org/specifications/
Thanks!
>
> Signed-off-by: Jie Deng <jiedeng@synopsys.com>
> ---
> Documentation/devicetree/bindings/net/ethernet.txt | 1 +
> include/linux/phy.h | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet.txt b/Documentation/devicetree/bindings/net/ethernet.txt
> index 0515095..2378f00 100644
> --- a/Documentation/devicetree/bindings/net/ethernet.txt
> +++ b/Documentation/devicetree/bindings/net/ethernet.txt
> @@ -28,6 +28,7 @@ The following properties are common to the Ethernet controllers:
> * "rtbi"
> * "smii"
> * "xgmii"
> + * "xlgmii"
> * "trgmii"
> - phy-connection-type: the same as "phy-mode" property but described in ePAPR;
> - phy-handle: phandle, specifies a reference to a node representing a PHY
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index feb8a98..b52f9f8 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -79,6 +79,7 @@
> PHY_INTERFACE_MODE_RTBI,
> PHY_INTERFACE_MODE_SMII,
> PHY_INTERFACE_MODE_XGMII,
> + PHY_INTERFACE_MODE_XLGMII,
> PHY_INTERFACE_MODE_MOCA,
> PHY_INTERFACE_MODE_QSGMII,
> PHY_INTERFACE_MODE_TRGMII,
> @@ -136,6 +137,8 @@ static inline const char *phy_modes(phy_interface_t interface)
> return "smii";
> case PHY_INTERFACE_MODE_XGMII:
> return "xgmii";
> + case PHY_INTERFACE_MODE_XLGMII:
> + return "xlgmii";
> case PHY_INTERFACE_MODE_MOCA:
> return "moca";
> case PHY_INTERFACE_MODE_QSGMII:
>
--
Florian
next prev parent reply other threads:[~2016-12-08 22:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 3:57 [PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC Jie Deng
2016-12-07 3:57 ` [PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII Jie Deng
2016-12-08 22:15 ` Florian Fainelli [this message]
2016-12-09 5:19 ` Jie Deng
2016-12-09 16:39 ` Andrew Lunn
2016-12-10 2:16 ` Jie Deng
2016-12-07 3:57 ` [PATCH net-next 2/2] net: ethernet: Initial driver for Synopsys DWC XLGMAC Jie Deng
2016-12-07 9:48 ` Pavel Machek
[not found] ` <bea5ea07-cbab-35fe-434c-1cfcb96225ef@synopsys.com>
2016-12-08 21:57 ` Pavel Machek
2016-12-12 8:26 ` kbuild test robot
2016-12-08 15:59 ` [PATCH net-next 0/2] " Alexandre Torgue
2016-12-09 4:47 ` Jie Deng
2016-12-09 15:15 ` Carlos Palminha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c8257d-9ad9-71bf-a969-77dbe37bd800@gmail.com \
--to=f.fainelli@gmail.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jie.Deng1@synopsys.com \
--cc=davem@davemloft.net \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).