From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761927AbcINLrm (ORCPT ); Wed, 14 Sep 2016 07:47:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:49149 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754527AbcINLrk (ORCPT ); Wed, 14 Sep 2016 07:47:40 -0400 Subject: Re: [PATCH 02/15] hisi_sas: save delivery queue write pointer To: John Garry , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1473176185-217808-1-git-send-email-john.garry@huawei.com> <1473176185-217808-3-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: <30d2ed09-d8b5-ef52-0bf5-847b4171e99c@suse.de> Date: Wed, 14 Sep 2016 13:47:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1473176185-217808-3-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2016 05:36 PM, John Garry wrote: > Optimise by saving an avoidable read in the > get_free_slot function. > The delivery queue write pointer will only be > updated by software, so don't bother re-reading > what was already written in the previous call > to start_delivery function. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas.h | 7 +++++++ > drivers/scsi/hisi_sas/hisi_sas_main.c | 5 +++++ > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 +++++++----- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 9 ++++++--- > 4 files changed, 25 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Cheers -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)