From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "jic23@kernel.org" <jic23@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>
Subject: Re: [PATCH] iio: imu: adis: assign value only if return code zero in read funcs
Date: Fri, 1 Nov 2019 09:25:36 +0000 [thread overview]
Message-ID: <30dad15e9b9090983451dcbef54b23589599e3b9.camel@analog.com> (raw)
In-Reply-To: <20191030115511.28975-1-alexandru.ardelean@analog.com>
On Wed, 2019-10-30 at 13:55 +0200, Alexandru Ardelean wrote:
> The inline read functions in the ADIS library don't check the return
> value
> of the `adis_read_reg()` function and assign the value of `tmp`
> regardless.
>
> Fix this by checking if return value is zero and only then assigning the
> value of `tmp`.
>
@Jonathan:
Please disregard this.
I will re-spin this as a series.
It turned out that the whole thing/changeset is much bigger than I
initially anticipated.
I think I found the reason why we (at ADI) weren't catching the ADIS
warnings/errors, before upstreaming.
It turns out, that we were only testing with ARM & ARM64 compilers, while
the compilers that were hitting us with warnings are x86_64. I do remember
[from past experiences] that different GCC compilers report different
[often valid] types of errors. But, if I don't need to work with too many
ARCHs, I do forget about this aspect.
In any case, I've updated our CI to also include a build-run with x86_64
for all ADI drivers.
And we may also extend this to cover the entire kernel [later].
Thanks
Alex
> Fixes: 57a1228a06b7a ("iio:imu:adis: Add support for 32bit registers")
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> include/linux/iio/imu/adis.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/iio/imu/adis.h b/include/linux/iio/imu/adis.h
> index 4c53815bb729..92aae14593bf 100644
> --- a/include/linux/iio/imu/adis.h
> +++ b/include/linux/iio/imu/adis.h
> @@ -129,7 +129,8 @@ static inline int adis_read_reg_16(struct adis *adis,
> unsigned int reg,
> int ret;
>
> ret = adis_read_reg(adis, reg, &tmp, 2);
> - *val = tmp;
> + if (ret == 0)
> + *val = tmp;
>
> return ret;
> }
> @@ -147,7 +148,8 @@ static inline int adis_read_reg_32(struct adis *adis,
> unsigned int reg,
> int ret;
>
> ret = adis_read_reg(adis, reg, &tmp, 4);
> - *val = tmp;
> + if (ret == 0)
> + *val = tmp;
>
> return ret;
> }
prev parent reply other threads:[~2019-11-01 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 11:55 [PATCH] iio: imu: adis: assign value only if return code zero in read funcs Alexandru Ardelean
2019-11-01 9:25 ` Ardelean, Alexandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30dad15e9b9090983451dcbef54b23589599e3b9.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).