From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Biggers <ebiggers@google.com>,
Eric Biggers <ebiggers@kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Jia Zhang <zhang.jia@linux.alibaba.com>,
"YiLin . Li" <YiLin.Li@linux.alibaba.com>
Subject: Re: [PATCH 1/3] crypto: tcrypt - Fix the wrong position of return value test statement
Date: Fri, 13 Aug 2021 15:38:18 +0800 [thread overview]
Message-ID: <30de4d0a-42ee-3115-981e-bedc701bceb8@linux.alibaba.com> (raw)
In-Reply-To: <20210812135943.mnuce4252wp4xi52@altlinux.org>
Hi Vitaly,
On 8/12/21 9:59 PM, Vitaly Chikunov wrote:
> Tianjia,
>
> On Thu, Aug 12, 2021 at 09:17:46PM +0800, Tianjia Zhang wrote:
>> The position of the return value test statement of crypto_aead_setkey()
>> is wrong, adjust to make it work properly.
>
> This commit message does not explain anything. It's nearly equivalent to
> "fix".
>
will update in next version.
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>> ---
>> crypto/tcrypt.c | 13 ++++++-------
>> 1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
>> index d73a42fdaa9b..73c97e085baf 100644
>> --- a/crypto/tcrypt.c
>> +++ b/crypto/tcrypt.c
>> @@ -612,6 +612,12 @@ static void test_aead_speed(const char *algo, int enc, unsigned int secs,
>> }
>> }
>> ret = crypto_aead_setkey(tfm, key, *keysize);
>
> Perhaps, you would say that return value of crypto_aead_setkey was lost.
>
Yes, good idea.
>> + if (ret) {
>> + pr_err("setkey() failed flags=%x\n",
>> + crypto_aead_get_flags(tfm));
>> + goto out;
>> + }
>> +
>> ret = crypto_aead_setauthsize(tfm, authsize);
>
> But, isn't now return value of crypto_aead_setauthsize is lost?
>
> Thanks,
>
Yes, it is needed.
I will move crypto_aead_setauthsize() call out of the loop, only need to
call it once after load transform.
Best regards,
Tianjia
>>
>> iv_len = crypto_aead_ivsize(tfm);
>> @@ -622,15 +628,8 @@ static void test_aead_speed(const char *algo, int enc, unsigned int secs,
>> printk(KERN_INFO "test %u (%d bit key, %d byte blocks): ",
>> i, *keysize * 8, bs);
>>
>> -
>> memset(tvmem[0], 0xff, PAGE_SIZE);
>>
>> - if (ret) {
>> - pr_err("setkey() failed flags=%x\n",
>> - crypto_aead_get_flags(tfm));
>> - goto out;
>> - }
>> -
>> sg_init_aead(sg, xbuf, bs + (enc ? 0 : authsize),
>> assoc, aad_size);
>>
>> --
>> 2.19.1.3.ge56e4f7
next prev parent reply other threads:[~2021-08-13 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 13:17 [PATCH 0/3] support test GCM/CCM mode for SM4 Tianjia Zhang
2021-08-12 13:17 ` [PATCH 1/3] crypto: tcrypt - Fix the wrong position of return value test statement Tianjia Zhang
2021-08-12 13:59 ` Vitaly Chikunov
2021-08-13 7:38 ` Tianjia Zhang [this message]
2021-08-12 13:17 ` [PATCH 2/3] crypto: testmgr - Add GCM/CCM mode test of SM4 algorithm Tianjia Zhang
2021-08-12 13:17 ` [PATCH 3/3] crypto: tcrypt: add GCM/CCM mode test for " Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30de4d0a-42ee-3115-981e-bedc701bceb8@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=YiLin.Li@linux.alibaba.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=ebiggers@kernel.org \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vt@altlinux.org \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).