From: Chao Yu <yuchao0@huawei.com>
To: Gao Xiang <gaoxiang25@huawei.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
"Joe Perches" <joe@perches.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
<linux-erofs@lists.ozlabs.org>, "Chao Yu" <chao@kernel.org>,
Miao Xie <miaoxie@huawei.com>, <weidu.du@huawei.com>,
Fang Wei <fangwei1@huawei.com>
Subject: Re: [PATCH v3 4/7] erofs: kill __packed for on-disk structures
Date: Fri, 30 Aug 2019 14:16:29 +0800 [thread overview]
Message-ID: <30f05f16-cefc-2d8e-4f2c-1775779101c9@huawei.com> (raw)
In-Reply-To: <20190830033643.51019-4-gaoxiang25@huawei.com>
On 2019/8/30 11:36, Gao Xiang wrote:
> As Christoph claimed "Please don't add __packed" [1],
> I have to remove all __packed except struct erofs_dirent here.
>
> Note that all on-disk fields except struct erofs_dirent
> (12 bytes with a 8-byte nid) in EROFS are naturally aligned.
>
> [1] https://lore.kernel.org/lkml/20190829095954.GB20598@infradead.org/
> Reported-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
next prev parent reply other threads:[~2019-08-30 6:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 3:00 [PATCH v2 1/7] erofs: on-disk format should have explicitly assigned numbers Gao Xiang
2019-08-30 3:00 ` [PATCH v2 2/7] erofs: some marcos are much more readable as a function Gao Xiang
2019-08-30 3:16 ` Joe Perches
2019-08-30 3:20 ` Gao Xiang
2019-08-30 3:36 ` [PATCH v3 1/7] erofs: on-disk format should have explicitly assigned numbers Gao Xiang
2019-08-30 3:36 ` [PATCH v3 2/7] erofs: some macros are much more readable as a function Gao Xiang
2019-08-30 3:38 ` [PATCH v4 " Gao Xiang
2019-08-30 6:11 ` [PATCH v3 " Chao Yu
2019-08-30 3:36 ` [PATCH v3 3/7] erofs: use a better form for complicated on-disk fields Gao Xiang
2019-08-30 3:36 ` [PATCH v3 4/7] erofs: kill __packed for on-disk structures Gao Xiang
2019-08-30 6:16 ` Chao Yu [this message]
2019-08-30 3:36 ` [PATCH v3 5/7] erofs: kill erofs_{init,exit}_inode_cache Gao Xiang
2019-08-30 6:17 ` Chao Yu
2019-08-30 3:36 ` [PATCH v3 6/7] erofs: remove all likely/unlikely annotations Gao Xiang
2019-08-30 6:25 ` Chao Yu
2019-08-30 6:31 ` Gao Xiang
2019-08-30 6:43 ` Chao Yu
2019-08-30 11:55 ` Dan Carpenter
2019-08-30 11:30 ` Dan Carpenter
2019-08-30 12:06 ` Gao Xiang
2019-08-30 15:46 ` Christoph Hellwig
2019-08-30 16:04 ` Gao Xiang
2019-08-31 10:57 ` Dan Carpenter
2019-08-30 3:36 ` [PATCH v3 7/7] erofs: redundant assignment in __erofs_get_meta_page() Gao Xiang
2019-08-30 6:25 ` Chao Yu
2019-08-30 16:28 ` Christoph Hellwig
2019-08-30 16:48 ` Gao Xiang
2019-08-30 15:25 ` [PATCH v3 1/7] erofs: on-disk format should have explicitly assigned numbers Gao Xiang
2019-08-30 15:45 ` [PATCH v2 2/7] erofs: some marcos are much more readable as a function Christoph Hellwig
2019-08-30 15:52 ` Gao Xiang
2019-08-30 15:56 ` Gao Xiang
2019-08-30 3:00 ` [PATCH v2 3/7] erofs: use a better form for complicated on-disk fields Gao Xiang
2019-08-30 3:29 ` Chao Yu
2019-08-30 3:00 ` [PATCH v2 4/7] erofs: kill __packed for on-disk structures Gao Xiang
2019-08-30 3:00 ` [PATCH v2 5/7] erofs: kill erofs_{init,exit}_inode_cache Gao Xiang
2019-08-30 3:00 ` [PATCH v2 6/7] erofs: remove all likely/unlikely annotations Gao Xiang
2019-08-30 3:00 ` [PATCH v2 7/7] erofs: reduntant assignment in __erofs_get_meta_page() Gao Xiang
2019-08-30 3:28 ` [PATCH v2 1/7] erofs: on-disk format should have explicitly assigned numbers Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30f05f16-cefc-2d8e-4f2c-1775779101c9@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fangwei1@huawei.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=weidu.du@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).