From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15A3C3A5A3 for ; Fri, 30 Aug 2019 06:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 846FA2186A for ; Fri, 30 Aug 2019 06:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbfH3GQn (ORCPT ); Fri, 30 Aug 2019 02:16:43 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:35232 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726452AbfH3GQn (ORCPT ); Fri, 30 Aug 2019 02:16:43 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id B455A2DCB625938A36D4; Fri, 30 Aug 2019 14:16:40 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 30 Aug 2019 14:16:29 +0800 Subject: Re: [PATCH v3 4/7] erofs: kill __packed for on-disk structures To: Gao Xiang , Dan Carpenter , Christoph Hellwig , "Joe Perches" , Greg Kroah-Hartman , CC: LKML , , "Chao Yu" , Miao Xie , , Fang Wei References: <20190830032006.GA20217@architecture4> <20190830033643.51019-1-gaoxiang25@huawei.com> <20190830033643.51019-4-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <30f05f16-cefc-2d8e-4f2c-1775779101c9@huawei.com> Date: Fri, 30 Aug 2019 14:16:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190830033643.51019-4-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/30 11:36, Gao Xiang wrote: > As Christoph claimed "Please don't add __packed" [1], > I have to remove all __packed except struct erofs_dirent here. > > Note that all on-disk fields except struct erofs_dirent > (12 bytes with a 8-byte nid) in EROFS are naturally aligned. > > [1] https://lore.kernel.org/lkml/20190829095954.GB20598@infradead.org/ > Reported-by: Christoph Hellwig > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,